Support Windows 10 1903 Light Theme #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support Windows 10 1903 Light Theme (Menu icon color)
ghost
approved these changes
Jun 15, 2019
celeron533
reviewed
Jun 15, 2019
Move GetWindows10SystemThemeSetting() to Util.cs WindowsThemeMode use enum Status var windowsThemeMode rename to windowsThemeMode Used `if else` to replace `switch case` Delete legacy commint (Some code). Increase contrast for icon.
celeron533
reviewed
Jun 26, 2019
Fixed bug of shadowsocks#2379 pullrequestreview-254461303 Redundant paintings when user move mouse on the icon, pixel by pixel.
|
Bug fixes. #2379 (comment) |
celeron533
added a commit
to celeron533/shadowsocks-windows
that referenced
this pull request
Jul 4, 2019
Support Windows 10 1903 Light Theme
|
我一直在用浅色主题，完全没影响啊。现在一适配，pac模式图标好暗呀。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Compiled the code with Visual Studio
What is the purpose of your pull request?
Description of your pull request and other information
Support Windows 10 1903 light theme. (Menu icon color adaptive, previous version icons are indistinguishable at light theme)
Icon more beautiful. (use alpha replace 128 gray)
支持 Windows10 1903 的“亮”主题色。（菜单图标颜色自适应，之前版本图标会在亮色主题下难以看见）
图标更加美观。（使用Alpha通道替换128灰色）
Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.