Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows 10 1903 Light Theme #2379

Merged
merged 3 commits into from Jul 6, 2019

Conversation

@TGSAN
Copy link
Contributor

commented Jun 4, 2019

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

Support Windows 10 1903 light theme. (Menu icon color adaptive, previous version icons are indistinguishable at light theme)
Icon more beautiful. (use alpha replace 128 gray)
支持 Windows10 1903 的“亮”主题色。(菜单图标颜色自适应,之前版本图标会在亮色主题下难以看见)
图标更加美观。(使用Alpha通道替换128灰色)

Explanation of your pull request in arbitrary form goes here. Please make sure the description explains the purpose and effect of your pull request and is worded well enough to be understood. Provide as much context and examples as possible.

Support Windows 10 1903 Light Theme (Menu icon color)
shadowsocks-csharp/View/MenuViewController.cs Outdated Show resolved Hide resolved
shadowsocks-csharp/View/MenuViewController.cs Outdated Show resolved Hide resolved
Move GetWindows10SystemThemeSetting() to Util.cs
WindowsThemeMode use enum
Status var windowsThemeMode rename to windowsThemeMode
Used `if else` to replace `switch case`
Delete legacy commint (Some code).
Increase contrast for icon.
@TGSAN

This comment has been minimized.

Copy link
Owner Author

commented on 95b760c Jun 15, 2019

  • Move GetWindows10SystemThemeSetting() to Util.cs
  • WindowsThemeMode use enum
  • Status value windowsThemeMode rename to windowsThemeMode
  • Used if else to replace switch case
  • Delete legacy commit note (Some code).
  • Increase contrast for icon.
Fixed bug of #2379 pullrequestreview-254461303
Redundant paintings when user move mouse on the icon, pixel by pixel.
@TGSAN

This comment has been minimized.

Copy link
Contributor Author

commented Jun 27, 2019

Bug fixes. #2379 (comment)

celeron533 added a commit to celeron533/shadowsocks-windows that referenced this pull request Jul 4, 2019
Support Windows 10 1903 Light Theme
@celeron533 celeron533 merged commit 66b94d4 into shadowsocks:master Jul 6, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@chensln

This comment has been minimized.

Copy link

commented Jul 14, 2019

我一直在用浅色主题,完全没影响啊。现在一适配,pac模式图标好暗呀。
0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.