Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃巸 PAC: workaround to exempt private IP ranges in whitelist mode #3008

Merged
merged 1 commit into from
Nov 2, 2020

Conversation

database64128
Copy link
Contributor

Please follow the guide below

  • You will be asked some questions, please read them carefully and answer honestly

  • Put an x into all the boxes [ ] relevant to your pull request (like that [x])

  • Use Preview tab to see how your pull request will actually look like

  • Searched for similar pull requests

  • Compiled the code with Visual Studio

  • Require translation update

  • Require document update (readme.md, wikipage, etc)

What is the purpose of your pull request?

  • Bug fix
  • Improvement
  • New feature

Description of your pull request and other information

@darkflame0
Copy link

Missing localhost.

@chenshaoju
Copy link
Collaborator

chenshaoju commented Oct 29, 2020

@darkflame0

private readonly static string[] _lanIP = {
"<local>",
"localhost",
"127.*",
"10.*",
"172.16.*",
"172.17.*",
"172.18.*",
"172.19.*",
"172.20.*",
"172.21.*",
"172.22.*",
"172.23.*",
"172.24.*",
"172.25.*",
"172.26.*",
"172.27.*",
"172.28.*",
"172.29.*",
"172.30.*",
"172.31.*",
"192.168.*"
};

@Loyalsoldier
Copy link
Contributor

Loyalsoldier commented Oct 31, 2020

@chenshaoju
Copy link
Collaborator

The quick test is passed, private IP (192.168.1.0/24 in my case) can working with "geositePreferDirect": false, and "geositePreferDirect": true, .

馃憤 Looks good to me, but someone else must approve.

@database64128 database64128 merged commit 73fa920 into master Nov 2, 2020
@database64128 database64128 deleted the pac-private-ip branch November 2, 2020 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

鏂扮増鏈琍AC浼氫唬鐞嗗眬鍩熺綉鍦板潃
4 participants