Remove ErrorBoundary component #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ted-byrd
approved these changes
Sep 2, 2023
ted-byrd
added a commit
that referenced
this pull request
Sep 2, 2023
* Update CHANGELOG * Add sample views to example app * Add faker data to example views * Update package-lock.json * Add config directory to example app * Add clean script, update build script * Move routes to config directory * Move theme to config * Move app config and profile to config files * Add whitespace * Refactor AppShell to more closely resemble MUI template * Change example app title * Prepare CHANGELOG for next release * Review unit tests for ErrorBoundary * Remove inaccessible view * Remove ts-ignore and alternate to empty string * Improve code coverage on PasswordForm * Update CHANGELOG * Update dependency versions * Improve README * Update README with development information * Refactor: fake data generation * Remove npm run verify step from dev env setup instructions * Clean up example components * Changed .nvmrc version to v18 * Add 'npm run build' to set up instructions in README * Fix build and clean scripts * Remove CSS stylesheets * Rename AppShell component to Dashboard * Renamed rendered component in AuthShell unit tests * Cleanup README, add section on running Storybook * Remove hello API endpoint from example * Refactor example components to add state * Upgrade Storybook * Add authentication pages * Add Supabase to the example * Add instructions for using Supabase in dev environment * WIP: Adding Supabase session management * Ignore Typescript error * Remove Supabase client calls from Signout component * Refactor scripts in package.json * 0.0.6 * Remove ErrorBoundary component (#54) --------- Co-authored-by: Ted Byrd <118465412+ted-byrd@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't buying us anything, and its bringing our test coverage down.