Fixes for Issue #4 #7
Conversation
|
Awesome job! 👍 Some feedback:
Great job overall! |
|
What it currently looks like at that particular breakpoint:
|
mySC.js
Outdated
| var song = 'https://soundcloud.com/chancetherapper/acid-rain-1'; | ||
| playSC(song, false); // false = don't autoPlay, true = autoPlay | ||
| getSCinfo(song); | ||
| var song1 = 'https://soundcloud.com/chancetherapper/acid-rain-1'; |
There was a problem hiding this comment.
Let's have a "song" array, and then loop through it.
mySC.js
Outdated
| playSC(song1, false); // false = don't autoPlay, true = autoPlay | ||
|
|
||
| getSCinfo(song1, 'thumbnail', true, true); | ||
| getSCinfo(song2, 'smallThumb1'); |
There was a problem hiding this comment.
Loop through these lines where the stop conditional is the number of items in our song array.
|
@shahzeb1 I've made those changes, how does it look now? I also changed the cursor used when you hover over the extra artwork and the buttons but can easily revert if you'd rather not have that. |
|
Awesome! Merged. |
I've attempted to implement the requested features here. Note that as part of my troubleshooting process I changed onto Bootstrap v4 - I think this was probably not necessary in the end but figured I might as well leave it on the newer version.