-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing the workbench license #307
Comments
I have no issues with the idea of doing this. Taking a quick look through the repository contributors list, I'd say there's a good chance we can get everyone to sign off on a license change to LGPL. I agree that this change fits well within the philosophy of the FreeCAD project. For potentially useful reference: I like the approach the MPV player developers took to tackling this exact problem: mpv-player/mpv#2033 |
@alexneufeld That's a really useful reference, thank you! |
I'm all for re-licensing to LGPL2.1, this is also compatible with @ulrich1a screw_maker license which the original WB was based on. |
waiting for response of: |
I've been working on the Polish translation of this cool workbench, and I don't mind changing the license. 😄 |
I have no objections to the LGPL2.1 license. |
I have also no objections to the LGPL2.1 license. |
Thanks for pinging, I wouldn't have noticed otherwise. No objection to the license change! |
Hi all, |
Thanks for ping, it's nice to know that this WB could join upstream FreeCAD. |
In my opinion, my share of contribution is rather small and do not think that I would have a saying in this. @prokoudine will there be an other Issue/Thread where one could give Suggestion of features that would be nice if they where implemented in this move to an Integrated workbench? This is since the most intelligent think to do, while moving this to FreeCAD, is to rewrite the core of this workbench in C++/Qt. |
@tobiasfalk I could be talking out of my arse, but I vaguely recall that @sliptonic and @shaise were in agreement that the unfolder shoud definitely be part of the core and thus be rewritten in C++. Once/if the relicensing of both WBs has green lights, there definitely should be review of both architecture, workflow, and UX/UI to come up with a sensible plan. |
No objection to the license change! |
And can either @prokoudine or @shaise make a check list with all the pinged people to make it easier to look up who already agreed?
|
(Copy the main post) - [X] @shaise
- [X] @alexneufeld
- [X] @riqueenz
- [ ] @FreeCAD-Tools
- [ ] @luzpaz
- [X] @hasecilu
- [ ] @berberic2
- [X] @Roy-043
- [ ] @EA32
- [ ] @elysium31
- [X] @kaktusus
- [X] @wavexx
- [X] @tobiasfalk
- [ ] @easyw
- [X] @fra589
- [ ] @wandrewkeech
- [ ] @algtgv
- [X] @hpbmo
- [ ] @chennes
- [ ] @ApexArray
- [ ] @JohanAR
- [ ] @elf128
- [ ] @chrido
- [ ] @spike77453
- [ ] @yorikvanhavre
- [ ] @f3nix |
@hasecilu, Thanks! great idea! |
Works for me! 👍 |
No objections here 👍
…On Thu, Dec 7, 2023 at 9:35 AM spike77453 ***@***.***> wrote:
Works for me! 👍
—
Reply to this email directly, view it on GitHub
<#307 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV3VF6XLO7EWJU7BVXKGTQDYIHV6BAVCNFSM6AAAAABAIGPZR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBVGY3DMNZQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I do not mind the change. |
No objection to the license change! |
No objection to the license change (and I think distributing this with FreeCAD would be a good idea :) ) |
No objections to the license change 👍 |
No objections, I'm barely a contributor to this project anyway :) |
No objections. |
No objection |
That is O.K. for me. |
Sorry to be late 😅 I agree! |
go for it! |
FYIO: What
|
@berberic2 , |
As I said: This is not a comprehensive analysis! |
@elf128 , thanks! noted! |
If their changes are still there, we would proceed by removing them. So If their code changes are no longer present than we can proceed without their reply. |
@FreeCAD-Tools is a man from Ukraine. We all know the current situation in that country. Give him some time. 😞 |
git shortlog --author=FreeCAD-Tools --author=EA32 --author=elysium --author=keech Click to view commitsAndy (2): Add IUT[A/B/C] heatset inserts for 3D print modelingAuto-sizing for IUTA/B/C heat sets EA32 (9): FreeCAD-Tools (49): Maksym Veremchuk (10): |
Or am I in the wrong? |
Hi! Sorry been afk on github for quite some time. |
great! |
No objections |
Pinging @FreeCAD-Tools @EA32 Could you guys comment here if this licence change is ok for you? |
I think we should post here the intention to change the license unless someone objects. Leave it for 30 days or so and then proceed. If either of the outstanding contributors complains, we can remove their contributions at a later date. |
Why not just make a PR changing it and then if no one complains in by the end of the week. It gets merged, and if the complaints come after this, then their work can be removed as you said. There are just 2 contributors that are missing to respond. In other words, way to wait for a month? This was posted on December 2023. |
This isn't a huge emergency. Changing the license won't immediately change anything. Before we can consider including the WB in Ondsel or in upstream FreeCAD there's more work to be done and nobody is standing up to do it yet. We have sheetmetal underway and many other important changes to work on. |
@shaise how much amd what did the two missing contribut. |
@tobiasfalk |
@shaise, Have you checked if they are active on GitHub still? They may have died or been jailed... |
@leoheck |
Two things. Second, they both contributed quite a lot, is that something that is a major part of the WB or can it be easily redone, if a approval of all is required. |
I asked ChatGPT to highlight the main differences between those two licences. I am not sure if this is correct tho.
|
Ping |
The Workbench Creation guide recommends licensing addons under the terms of LGPL2.1 — the same license that FreeCAD source code is available under. The recommendation’s rationale is that it should be possible to ship a FreeCAD distribution, either upstream, or a custom one, with 3rd-party addons that are considered useful. While a workbench developer is free to choose an alternative license, doing so may impact the long-term viability and use of the workbench and should be considered carefully.
Ondsel would like to integrate the Fasteners workbench into its distribution of FreeCAD, because the company’s market study suggests that this feature is expected to be available in 3D CAD programs by default. We want to provide our end-users the best possible experience. There’s a possibility that this workbench then will go back to become part of upstream FreeCAD. However neither the upstream version of FreeCAD, nor Ondsel’s version of FreeCAD can distribute this workbench as long as it’s licensed under the terms of GPL2.
We are asking for a conversation about relicensing this workbench under LGPL2+ or another compatible license to allow wider distribution.
The text was updated successfully, but these errors were encountered: