Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retain Shape Color and Transparency of base object #246

Merged
merged 9 commits into from Aug 4, 2022
Merged

Retain Shape Color and Transparency of base object #246

merged 9 commits into from Aug 4, 2022

Conversation

Syres916
Copy link
Contributor

@Syres916 Syres916 commented Aug 4, 2022

@Syres916
Retain Shape Color and Transparency of base object
648eac6 
See Issue FreeCAD/FreeCAD#7085
@Syres916
Retain Shape Color and Transparency of base object
9e2a889 
See Issue FreeCAD/FreeCAD#7085
@Syres916
Retain Shape Color and Transparency of base object
f518e35 
See Issue FreeCAD/FreeCAD#7085
@Syres916
Retain Shape Color and Transparency of base object
0104beb 
See Issue FreeCAD/FreeCAD#7085
@Syres916
Retain Shape Color and Transparency of base object
ca25f90 
See Issue FreeCAD/FreeCAD#7085
@Syres916
Retain Shape Color and Transparency of base object
c51fe26 
See Issue FreeCAD/FreeCAD#7085
@Syres916
Retain Shape Color and Transparency of base object
4ad0d23 
See Issue FreeCAD/FreeCAD#7085
@Syres916
Retain Shape Color and Transparency of base object
83eeaef 
See Issue FreeCAD/FreeCAD#7085
@Syres916
Retain Shape Color and Transparency of base object
0f42d3c 
See Issue FreeCAD/FreeCAD#7085
@Syres916 Syres916 mentioned this pull request Aug 4, 2022
Open
@shaise shaise merged commit 954c779 into shaise:master Aug 4, 2022
shaise added a commit that referenced this pull request Aug 4, 2022
@shaise
update version to pr #246. Also change it to a common function
73ecc8a
@shaise
Copy link
Owner

shaise commented Aug 4, 2022

Hi @Syres916,

Thanks for this important fix!
Hope its ok with you, I have converted all your changes to use functions instead of repeated code, this way if we have a solution to face colors, we can do it in a single place.

Thanks!
shai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Syres916 @shaise