Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keystatuseschange Event should show expiration time in same format as event time. #42

Closed
jrummell-chromium opened this issue Mar 29, 2022 · 0 comments · Fixed by #48 or #49
Closed

keystatuseschange Event should show expiration time in same format as event time. #42

jrummell-chromium opened this issue Mar 29, 2022 · 0 comments · Fixed by #48 or #49
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
Backlog

Comments

@jrummell-chromium
Copy link
Contributor

Currently the keystatuseschange Event shows expiration as a Unix epoch time, for example:

MediaKeySession keystatuseschange Event instance {}
Associated value: {
  expiration: 1648595361000,
  ...
}

It would be nice if it was displayed in a human readable form, e.g. Tue Mar 29 2022 16:09:21 GMT-0700 (Pacific Daylight Time), the same format used to display the event timestamp.
@joeyparrish joeyparrish added type: enhancement New feature or request priority: P3 Useful but not urgent labels Mar 29, 2022
@github-actions github-actions bot added this to the Backlog milestone Mar 29, 2022
@jrummell-chromium jrummell-chromium mentioned this issue Jun 23, 2022
Merged
joeyparrish pushed a commit that referenced this issue Jun 24, 2022
@jrummell-chromium
fix: Display keystatuseschange.expiration as a Date (#48)
d5d15f6 
The values is the number of milliseconds from epoch which isn't
readable, so display it as a Date if possible.

Fixes #42
@github-actions github-actions bot mentioned this issue Jun 24, 2022
Merged
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Aug 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
Backlog
2 participants
@joeyparrish @jrummell-chromium