-
Notifications
You must be signed in to change notification settings - Fork 492
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix incorrrect segment name with $Time$ in segment_template
The time for the previous segment was used when generating the segment name. This resulted in the first segment being overwritten and mismatching manifest and media files. It led to playback problems. Issue #472. Change-Id: Ia8130ce261585e1a2ede83b26de3e32508de087f
- Loading branch information
Showing
11 changed files
with
49 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+16.7 KB
.../app/test/testdata/live-static-profile-with-time-in-segment-name/bear-640x360-audio-0.m4s
Binary file not shown.
Binary file added
BIN
+16 KB
.../test/testdata/live-static-profile-with-time-in-segment-name/bear-640x360-audio-45056.m4s
Binary file not shown.
Binary file added
BIN
+9.41 KB
.../test/testdata/live-static-profile-with-time-in-segment-name/bear-640x360-audio-89088.m4s
Binary file not shown.
Binary file added
BIN
+793 Bytes
...p/test/testdata/live-static-profile-with-time-in-segment-name/bear-640x360-audio-init.mp4
Binary file not shown.
Binary file added
BIN
+97.1 KB
.../app/test/testdata/live-static-profile-with-time-in-segment-name/bear-640x360-video-0.m4s
Binary file not shown.
Binary file added
BIN
+119 KB
.../test/testdata/live-static-profile-with-time-in-segment-name/bear-640x360-video-30030.m4s
Binary file not shown.
Binary file added
BIN
+77.9 KB
.../test/testdata/live-static-profile-with-time-in-segment-name/bear-640x360-video-60060.m4s
Binary file not shown.
Binary file added
BIN
+859 Bytes
...p/test/testdata/live-static-profile-with-time-in-segment-name/bear-640x360-video-init.mp4
Binary file not shown.
28 changes: 28 additions & 0 deletions
28
packager/app/test/testdata/live-static-profile-with-time-in-segment-name/output.mpd
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<!--Generated with https://github.com/google/shaka-packager version <tag>-<hash>-<test>--> | ||
<MPD xmlns="urn:mpeg:dash:schema:mpd:2011" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xlink="http://www.w3.org/1999/xlink" xsi:schemaLocation="urn:mpeg:dash:schema:mpd:2011 DASH-MPD.xsd" xmlns:cenc="urn:mpeg:cenc:2013" profiles="urn:mpeg:dash:profile:isoff-live:2011" minBufferTime="PT2S" type="static" mediaPresentationDuration="PT2.7360665798187256S"> | ||
<Period id="0"> | ||
<AdaptationSet id="0" contentType="video" width="640" height="360" frameRate="30000/1001" segmentAlignment="true" par="16:9"> | ||
<Representation id="0" bandwidth="974122" codecs="avc1.64001e" mimeType="video/mp4" sar="1:1"> | ||
<SegmentTemplate timescale="30000" initialization="bear-640x360-video-init.mp4" media="bear-640x360-video-$Time$.m4s" startNumber="1"> | ||
<SegmentTimeline> | ||
<S t="0" d="30030" r="1"/> | ||
<S t="60060" d="22022"/> | ||
</SegmentTimeline> | ||
</SegmentTemplate> | ||
</Representation> | ||
</AdaptationSet> | ||
<AdaptationSet id="1" contentType="audio" segmentAlignment="true"> | ||
<Representation id="1" bandwidth="133929" codecs="mp4a.40.2" mimeType="audio/mp4" audioSamplingRate="44100"> | ||
<AudioChannelConfiguration schemeIdUri="urn:mpeg:dash:23003:3:audio_channel_configuration:2011" value="2"/> | ||
<SegmentTemplate timescale="44100" initialization="bear-640x360-audio-init.mp4" media="bear-640x360-audio-$Time$.m4s" startNumber="1"> | ||
<SegmentTimeline> | ||
<S t="0" d="45056"/> | ||
<S t="45056" d="44032"/> | ||
<S t="89088" d="31744"/> | ||
</SegmentTimeline> | ||
</SegmentTemplate> | ||
</Representation> | ||
</AdaptationSet> | ||
</Period> | ||
</MPD> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters