Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio and video out of sync with $Time$ in SegmentTemplate #472

Closed
kaushikkunal99 opened this issue Sep 12, 2018 · 13 comments
Closed

Audio and video out of sync with $Time$ in SegmentTemplate #472

kaushikkunal99 opened this issue Sep 12, 2018 · 13 comments
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@kaushikkunal99
Copy link

System info

AWS AMi
Latest packager version

Issue and steps to reproduce the problem

Audio and Video are out of sync

Packager Command:
5fa3c3ae-63d4-41e6-8065-468c3d0f59c1.txt

/opt/software/packager in=TMP/wm/A/ToS_216p_1M/video.mp4,stream=audio,init_segment=wm/audio/und/mp4a/init.mp4,segment_template=wm/audio/und/mp4a/seg_$Time$.m4s in=TMP/wm/A/ToS_216p_1M/video.mp4,stream=video,init_segment=tmp/216/A/wm/video/avc1/ToS_216p_1M/seg_init_0.mp4,segment_template=tmp/216/A/wm/video/avc1/ToS_216p_1M/seg_$Time$.m4s in=TMP/wm/B/ToS_216p_1M/video.mp4,stream=video,init_segment=tmp/216/B/wm/video/avc1/ToS_216p_1M/seg_init_0.mp4,segment_template=tmp/216/B/wm/video/avc1/ToS_216p_1M/seg_$Time$.m4s --generate_static_mpd --mpd_output wm/.mpd --enable_widevine_encryption --key_server_url --content_id --signer spedmg --aes_signing_key --generate_dash_if_iop_compliant_mpd=false --aes_signing_iv

What is the expected result?
Audio video in sync

What happens instead?
We tried on bitmovin player it works fine for few minutes and then starts to go out of sync.

@kqyang
Copy link
Collaborator

kqyang commented Sep 12, 2018

@kaushikkunal99 Can you share the source content and packaged outputs? You can email it to shaka-packager-issues@google.com if it cannot be shared publicly.

@kaushikkunal99
Copy link
Author

@kqyang I have emailed the urls. Can you take a look?

@kqyang kqyang changed the title Audio and video out of sync Audio and video out of sync with $Time$ in SegmentTemplate Sep 12, 2018
@kqyang kqyang added type: bug Something isn't working correctly and removed needs triage labels Sep 12, 2018
@kqyang kqyang added this to the v2.3 milestone Sep 12, 2018
@kqyang
Copy link
Collaborator

kqyang commented Sep 12, 2018

@kaushikkunal99 Thanks for the streams. I have traced down the bug to the handling of $Time$ in segment template. I am working on the fix.

In the mean time, you can use "$Number$" instead of "$Time$" in segment template. We recommend "$Number$" over "$Time$" as it results in more organized outputs and it is also simpler in player side.

shaka-bot pushed a commit that referenced this issue Sep 13, 2018
The time for the previous segment was used when generating the segment
name. This resulted in the first segment being overwritten and
mismatching manifest and media files. It led to playback problems.

Issue #472.

Change-Id: Ia8130ce261585e1a2ede83b26de3e32508de087f
@kqyang
Copy link
Collaborator

kqyang commented Sep 13, 2018

@kaushikkunal99 Can you try the fix I just submitted?

@kqyang kqyang self-assigned this Sep 13, 2018
@kaushikkunal99
Copy link
Author

kaushikkunal99 commented Sep 13, 2018 via email

@kqyang
Copy link
Collaborator

kqyang commented Sep 17, 2018

@kaushikkunal99 So looks like there are two separate issues.

  • Incorrect segment due to a bug in the handling of $Time$ in Shaka Packager
  • Out of sync problem in the source stream due to frame rate 23.97

Have you had a chance to try out the new packager? Can we close the issue now?

@kqyang kqyang added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Sep 17, 2018
kqyang added a commit that referenced this issue Sep 17, 2018
The time for the previous segment was used when generating the segment
name. This resulted in the first segment being overwritten and
mismatching manifest and media files. It led to playback problems.

Issue #472.

Change-Id: Ia8130ce261585e1a2ede83b26de3e32508de087f
@kaushikkunal99
Copy link
Author

hi @kqyang seems like we are not able to install the latest version of packager on AWS ami.
Below is the step its failing. Could you help us with this?

[root@ip-10-1-34-59 src]# ninja -C out/Release
ninja: Entering directory `out/Release'
[493/1609] LINK protoc
FAILED: protoc
../../packager/third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,-z,now -Wl,-z,relro -Wl,--fatal-warnings -Wl,-z,defs -pthread -Wl,-z,noexecstack -fPIC -Wl,--disable-new-dtags -m64 --sysroot=/opt/software/test/shaka_packager/src/packager/build/linux/debian_wheezy_amd64-sysroot -L/opt/software/test/shaka_packager/src/packager/build/linux/debian_wheezy_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=/opt/software/test/shaka_packager/src/packager/build/linux/debian_wheezy_amd64-sysroot/lib/x86_64-linux-gnu -L/opt/software/test/shaka_packager/src/packager/build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=/opt/software/test/shaka_packager/src/packager/build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu -L/opt/software/test/shaka_packager/src/packager/build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -Wl,-rpath-link=/opt/software/test/shaka_packager/src/packager/build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -L/opt/software/test/shaka_packager/src/packager/build/linux/debian_wheezy_amd64-sysroot/usr/lib -Wl,-rpath-link=/opt/software/test/shaka_packager/src/packager/build/linux/debian_wheezy_amd64-sysroot/usr/lib -Wl,-O1 -Wl,--as-needed -Wl,--gc-sections -Wl,--no-as-needed -lpthread -Wl,--as-needed -o protoc -Wl,--start-group obj/third_party/protobuf/src/google/protobuf/compiler/protoc.main.o obj/third_party/protobuf/libprotoc_lib.a obj/third_party/protobuf/libprotobuf_full_do_not_use.a -Wl,--end-group
/usr/bin/ld: this linker was not configured to use sysroots
clang: error: linker command failed with exit code 1 (use -v to see invocation)
[530/1609] CC obj/third_party/boringssl/src/crypto/fipsmodule/boringssl.bcm.o
ninja: build stopped: subcommand failed.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Sep 19, 2018
@kqyang
Copy link
Collaborator

kqyang commented Sep 19, 2018

@kaushikkunal99 Have you run "gclient sync" or "gclient runhooks" after syncing to latest release?

@kaushikkunal99
Copy link
Author

@kqyang yes i did. I am trying a fresh install per your documentation.

@kaushikkunal99
Copy link
Author

@kqyang any info on this?

@kqyang
Copy link
Collaborator

kqyang commented Sep 20, 2018

I am trying a fresh install per your documentation.

Are you seeing the same problem with a fresh install?

@kqyang
Copy link
Collaborator

kqyang commented Oct 8, 2018

@kaushikkunal99 Are you still seeing problems?

@kqyang kqyang added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 8, 2018
@shaka-bot
Copy link
Collaborator

Closing due to inactivity. If this is still an issue for you or if you have further questions, you can ask us to reopen or have the bot reopen it by including @shaka-bot reopen in a comment.

@shaka-bot shaka-bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Oct 15, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 14, 2018
@shaka-project shaka-project locked and limited conversation to collaborators Dec 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

3 participants