fixup! feat: enable uninstalling PatchedMediaKeysApple

shaka-project · Sep 15, 2022 · 22b8eaa · 22b8eaa
1 parent 91ac706
commit 22b8eaa
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/lib/polyfill/patchedmediakeys_apple.js b/lib/polyfill/patchedmediakeys_apple.js
@@ -38,9 +38,13 @@ shaka.polyfill.PatchedMediaKeysApple = class {
 
     if (enableUninstall) {
       this.enableUninstall = true;
-      // eslint-disable-next-line no-restricted-syntax
-      this.originalHTMLMediaElementPrototypeMediaKeys = HTMLMediaElement
-          .prototype.mediaKeys;
+      this.originalHTMLMediaElementPrototypeMediaKeys =
+        /** @type {!Object} */ (
+          Object.getOwnPropertyDescriptor(
+              // eslint-disable-next-line no-restricted-syntax
+              HTMLMediaElement.prototype, 'mediaKeys',
+          )
+        );
       // eslint-disable-next-line no-restricted-syntax
       this.originalHTMLMediaElementPrototypeSetMediaKeys = HTMLMediaElement
           .prototype.setMediaKeys;
@@ -86,9 +90,12 @@ shaka.polyfill.PatchedMediaKeysApple = class {
     shaka.log.info('Un-installing Apple-prefixed EME');
 
     this.enableUninstall = false;
-    // eslint-disable-next-line no-restricted-syntax
-    HTMLMediaElement.prototype['mediaKeys'] = this
-        .originalHTMLMediaElementPrototypeMediaKeys;
+    Object.defineProperty(
+        // eslint-disable-next-line no-restricted-syntax
+        HTMLMediaElement.prototype,
+        'mediaKeys',
+        this.originalHTMLMediaElementPrototypeMediaKeys,
+    );
     // eslint-disable-next-line no-restricted-syntax
     HTMLMediaElement.prototype.setMediaKeys = this
         .originalHTMLMediaElementPrototypeSetMediaKeys;