Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concurrency Issues with Multiple Storage Instances #1047

Closed
vaage opened this issue Oct 3, 2017 · 1 comment
Closed

Concurrency Issues with Multiple Storage Instances #1047

vaage opened this issue Oct 3, 2017 · 1 comment
Assignees
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@vaage
Copy link
Contributor

vaage commented Oct 3, 2017

Have you read the FAQ and checked for duplicate issues:
No

What version of Shaka Player are you using:
Master

Can you reproduce the issue with our latest release version:

Can you reproduce the issue with the latest code from master:
Yes

Are you using the demo app or your own custom app:
Custom App

If custom app, can you reproduce the issue using our demo app:
No. There are modifications needed to reproduce this bug as the demo app does not support concurrent downloads.

What browser and OS are you using:
Chrome on Mac

What are the manifest and license server URIs:
(you can send the URIs to shaka-player-issues@google.com instead, but please use GitHub and the template for the rest)

Using content from the demo app.

What did you do?

Create multiple instances of shaka.offline.Storage to download separate copies of content. For testing I had each instance download the same content.

What did you expect to happen?

I expected at content would download in parallel and would be playable offline after.

What actually happened?

The content downloads in parallel but they all use the same key so you lose all but one copy of the data. Since I had each instance download the same content, the one copy was still playable. I do not know what would happen if they were downloading different content.

@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Oct 3, 2017
@joeyparrish joeyparrish added this to the v2.3.0 milestone Oct 3, 2017
@joeyparrish
Copy link
Member

We have not been tagging this issue in commits so far. I believe these are the relevant commits to date:

shaka-bot pushed a commit that referenced this issue Dec 14, 2017
Instead of storing uris for SegmentDataDB in SegmentDB, store the
actual key so that we don't need to convert back-and-forth so
often.

Issue #1047

Change-Id: I2f6d1bc1e58abd7a210097dea757d1e2fc9d4cac
shaka-bot pushed a commit that referenced this issue Dec 14, 2017
Create DBUtils to hold code that will be useful to updating code
outside of DBEngine.

Issue #1047

Change-Id: If759fd0d778f42e6114e82e9274a053af420ad35
shaka-bot pushed a commit that referenced this issue Dec 14, 2017
Create the pattern for how to handle database upgrades. As of this
change the only upgrade supported is from version 0 (no database).

Issue #1047

Change-Id: I9f889a9e39a190e926cf06f0720a5371bc3c59af
shaka-bot pushed a commit that referenced this issue Dec 15, 2017
Changed our stores in IndexedDB to use auto increment for the keys
so that we no longer need to track current ids anymore.

Issue #1047

Change-Id: I765ba19810fce03ec8e4d968cbf8cf383355be6d
shaka-bot pushed a commit that referenced this issue Dec 16, 2017
externs/shaka/offline.js now represents the data types for Shaka Player
Offline V2. All offline shaka player code uses the new version and all
V1 and transitional code has been removed.

Issue #1047

Change-Id: Ia43f8d8d11426e823629e5fcd27c4e1e0ce400d3
@vaage vaage closed this as completed Dec 18, 2017
shaka-bot pushed a commit that referenced this issue Dec 18, 2017
Added a DB Upgrade path for converting content from version 1
to the version 2 format.

Issue #1047

Change-Id: Id8dc626d8289b08ca300c40b137173c0c6ec9d35
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants