Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DRM config for serverCertificate to serverCertificateUri #1906

Closed
joeyparrish opened this issue Apr 29, 2019 · 6 comments · Fixed by #3358
Closed

Change DRM config for serverCertificate to serverCertificateUri #1906

joeyparrish opened this issue Apr 29, 2019 · 6 comments · Fixed by #3358
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@joeyparrish
Copy link
Member

Have you read the FAQ and checked for duplicate open issues?
Yes

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Instead of the app needing to request the server cert, DrmEngine should be capable of doing it for you on demand. The serverCertificate config should be changed into serverCertificateUri.

Describe alternatives you've considered
None come to mind, other than the status quo.

@joeyparrish joeyparrish added the type: enhancement New feature or request label Apr 29, 2019
@TheModMaker
Copy link
Contributor

The server certificate is optional, if not given, the browser should request one if it needs it. The reason to set a server certificate is to avoid the extra network request if the app already has it. I assume this is coming from Fairplay, which requires the server certificate first? For Widevine, if it needs a server certificate, it will send a license request for one first, so we don't need to handle server certificates at all.

@joeyparrish
Copy link
Member Author

Yes, this comes up with FairPlay, and with the demo app, which takes a URI but configures the player with the actual cert.

@shaka-bot shaka-bot added this to the Backlog milestone Apr 29, 2019
@mseeley
Copy link

mseeley commented Sep 6, 2019

Hi folks. Just leaving a note that a serverCertificateUri drm config option is a great idea. It's straightforward to fetch the server certificate before configuring Shaka but it does require adding an async step before configuring Shaka.

Hiding the async certificate loading behind the already async player.load activity would make for a cleaner client implementation.

@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@mseeley
Copy link

mseeley commented Oct 28, 2020

Updated to 2.5x -> 3.0.5 enabled our app to eliminate the fairPlayTransform bool and initDataTransform helper from our FairPlay configuration. A code comment referenced back to this issue.

Just leaving a note that handling the server certificate load within Shaka would eliminate async sequencing in clients. Absolutely only an incremental nice-to-have, but, still nice to have.

Thanks for everything you all do. :)

@valotvince
Copy link
Contributor

I'll work on a PR on that matter 👍

@mseeley
Copy link

mseeley commented Jun 15, 2021

@joeyparrish looks like 9b4502c (and cleanup commit) missed the 3.1 cut. Are there plans to release an update including this change before 3.2 is minted?

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 2, 2021
@shaka-project shaka-project locked and limited conversation to collaborators Jul 2, 2021
@joeyparrish joeyparrish modified the milestones: Backlog, v3.2 Jul 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants