-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change DRM config for serverCertificate to serverCertificateUri #1906
Comments
The server certificate is optional, if not given, the browser should request one if it needs it. The reason to set a server certificate is to avoid the extra network request if the app already has it. I assume this is coming from Fairplay, which requires the server certificate first? For Widevine, if it needs a server certificate, it will send a license request for one first, so we don't need to handle server certificates at all. |
Yes, this comes up with FairPlay, and with the demo app, which takes a URI but configures the player with the actual cert. |
Hi folks. Just leaving a note that a Hiding the async certificate loading behind the already async |
Updated to 2.5x -> 3.0.5 enabled our app to eliminate the Just leaving a note that handling the server certificate load within Shaka would eliminate async sequencing in clients. Absolutely only an incremental nice-to-have, but, still nice to have. Thanks for everything you all do. :) |
I'll work on a PR on that matter 👍 |
@joeyparrish looks like 9b4502c (and cleanup commit) missed the 3.1 cut. Are there plans to release an update including this change before 3.2 is minted? |
Have you read the FAQ and checked for duplicate open issues?
Yes
Is your feature request related to a problem? Please describe.
No
Describe the solution you'd like
Instead of the app needing to request the server cert, DrmEngine should be capable of doing it for you on demand. The serverCertificate config should be changed into serverCertificateUri.
Describe alternatives you've considered
None come to mind, other than the status quo.
The text was updated successfully, but these errors were encountered: