Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing "Edit" button unstores custom asset, but does not update "stored" button. #2200

Closed
theodab opened this issue Oct 18, 2019 · 1 comment · Fixed by #5936
Closed

Pressing "Edit" button unstores custom asset, but does not update "stored" button. #2200

theodab opened this issue Oct 18, 2019 · 1 comment · Fixed by #5936
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.7

Comments

@theodab
Copy link
Collaborator

theodab commented Oct 18, 2019

If you press the "Edit" button on a custom asset, if that asset was stored, it is removed from the database. This is because we cannot guarantee that the stored data is still accurate, since you might change the URI or such. However, this process does not update the icon that tells you whether or not the asset is stored.
@theodab theodab added type: bug Something isn't working correctly component: demo page The issue is in the demo page; does not affect production applications labels Oct 18, 2019
@shaka-bot shaka-bot added this to the v2.6 milestone Oct 18, 2019
@theodab
Copy link
Collaborator Author

theodab commented Jan 10, 2020

Ok, I also ran into a situation where pressing "edit" did not unstore the asset.
Hm. This is annoying.

@joeyparrish joeyparrish modified the milestones: v2.6, Backlog Feb 12, 2020
@joeyparrish joeyparrish added the priority: P3 Useful but not urgent label May 5, 2021
@avelad avelad modified the milestones: Backlog, v5.0 Nov 27, 2023
@avelad avelad mentioned this issue Nov 27, 2023
Merged
avelad added a commit that referenced this issue Nov 28, 2023
@avelad
fix(Demo): Pressing "Edit" button unstores custom asset, but does not…
82b958f 
… update "stored" button (#5936)

Fixes #2200
avelad added a commit that referenced this issue Nov 30, 2023
@avelad
fix(Demo): Pressing "Edit" button unstores custom asset, but does not…
7e2e543 
… update "stored" button (#5936)

Fixes #2200
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
fix(Demo): Pressing "Edit" button unstores custom asset, but does not…
dc87096 
… update "stored" button (shaka-project#5936)

Fixes shaka-project#2200
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 27, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 27, 2024
joeyparrish pushed a commit that referenced this issue Feb 17, 2024
@avelad @joeyparrish
fix(Demo): Pressing "Edit" button unstores custom asset, but does not…
30a71f2 
… update "stored" button (#5936)

Fixes #2200
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.7
4 participants
@joeyparrish @avelad @shaka-bot @theodab