Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Demo): Pressing "Edit" button unstores custom asset, but does not update "stored" button #5936

Merged
merged 1 commit into from
Nov 28, 2023
Merged

fix(Demo): Pressing "Edit" button unstores custom asset, but does not update "stored" button #5936

merged 1 commit into from
Nov 28, 2023

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 27, 2023

Fixes #2200

@avelad avelad added type: bug Something isn't working correctly component: demo page The issue is in the demo page; does not affect production applications priority: P3 Useful but not urgent labels Nov 27, 2023
@avelad avelad added this to the v5.0 milestone Nov 27, 2023
@avelad avelad requested a review from theodab November 27, 2023 11:46
@avelad avelad mentioned this pull request Nov 27, 2023
Closed
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@avelad avelad merged commit 82b958f into shaka-project:main Nov 28, 2023
14 of 19 checks passed
@shaka-bot shaka-bot mentioned this pull request Nov 28, 2023
Merged
@avelad avelad deleted the demo-store-error branch November 28, 2023 07:45
avelad added a commit that referenced this pull request Nov 30, 2023
@avelad
fix(Demo): Pressing "Edit" button unstores custom asset, but does not…
7e2e543 
… update "stored" button (#5936)

Fixes #2200
@shaka-bot shaka-bot mentioned this pull request Nov 30, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
fix(Demo): Pressing "Edit" button unstores custom asset, but does not…
dc87096 
… update "stored" button (shaka-project#5936)

Fixes shaka-project#2200
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jan 27, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jan 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theodab theodab theodab approved these changes

Assignees
No one assigned
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

Pressing "Edit" button unstores custom asset, but does not update "stored" button.
3 participants
@avelad @shaka-bot @theodab