Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Shaka CEA parser for TS #3674

Closed
avelad opened this issue Sep 30, 2021 · 6 comments · Fixed by #4697
Closed

Use Shaka CEA parser for TS #3674

avelad opened this issue Sep 30, 2021 · 6 comments · Fixed by #4697
Assignees
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@avelad
Copy link
Collaborator

avelad commented Sep 30, 2021

Have you read the FAQ and checked for duplicate open issues? YES

Is your feature request related to a problem? Please describe.

Right now there is the forceTransmuxTS setting to parse CEA-608 on devices that natively support TS, but this involves using mux.js and transmuxing TS to MP4.

Describe the solution you'd like

Since we have a CEA-608 parser for MP4, the idea would be to extend it to support TS.

Describe alternatives you've considered

Leave current behavior

@avelad avelad added the type: enhancement New feature or request label Sep 30, 2021
@shaka-bot shaka-bot added this to the Backlog milestone Sep 30, 2021
@avelad avelad changed the title Remove forceTransmuxTS and use Shaka CEA in this case. Remove forceTransmuxTS and use Shaka CEA instead Sep 30, 2021
@avelad
Copy link
Collaborator Author

avelad commented Sep 30, 2021

Note: there is native TS on Edge, Xbox, and Chromecast.

@theodab theodab added the priority: P3 Useful but not urgent label Sep 30, 2021
@avelad
Copy link
Collaborator Author

avelad commented Apr 11, 2022

With 8a3bed7 I think it would be good to remove this dependency. @theodab what do you think?

@theodab
Copy link
Collaborator

theodab commented Apr 13, 2022

It sounds reasonable as a feature. I'm not sure if we could justify getting rid of mux.js support altogether, but extending the CEA-608 parser to not require the intermediary step of turning TS into MP4 would be nice performance-wise.

I don't think this is something the Google Cast team is interested in, though, so I wouldn't expect us to get around to it anytime soon. I'll mark this as seeking PRs for now.

@theodab theodab added the flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this label Apr 13, 2022
@avelad
Copy link
Collaborator Author

avelad commented Apr 13, 2022

@theodab Do you know if the Cast team wants only DASH or is also interested in migrating and using ShakaPlayer for HLS as well?

@joeyparrish
Copy link
Member

We would like to use Shaka for HLS, and TS in HLS isn't going away any time soon. (Though it saddens me to admit it.) So yes, we should extend the CEA parser to support TS and drop this flag.

@joeyparrish
Copy link
Member

Looking at this again, forceTransmuxTS isn't only useful for CEA. It's also useful for working around broken platforms.

So long as we have transmuxing with mux.js, I think we should give apps the option to force us to transmux TS, even when the platform claims to support it.

But I'm still in favor of using our native CEA parser for TS as soon as we can.

@joeyparrish joeyparrish added this to In progress in HLS Improvements Aug 29, 2022
@joeyparrish joeyparrish moved this from In progress to To do in HLS Improvements Aug 29, 2022
@joeyparrish joeyparrish changed the title Remove forceTransmuxTS and use Shaka CEA instead Use Shaka CEA parser for TS Aug 29, 2022
@avelad avelad self-assigned this Nov 11, 2022
@avelad avelad moved this from To do to In progress in HLS Improvements Nov 11, 2022
@avelad avelad modified the milestones: Backlog, v4.4 Nov 11, 2022
@avelad avelad added component: captions/subtitles The issue involves captions or subtitles and removed flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this labels Nov 11, 2022
avelad added a commit that referenced this issue Nov 28, 2022
Closes #3674

Co-authored-by: Joey Parrish <joeyparrish@google.com>
@avelad avelad moved this from In progress to Done in HLS Improvements Nov 28, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jan 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2023
swac pushed a commit to loomhq/shaka-player that referenced this issue Feb 9, 2023
Closes shaka-project#3674

Co-authored-by: Joey Parrish <joeyparrish@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants