-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Shaka CEA parser for TS #3674
Comments
Note: there is native TS on Edge, Xbox, and Chromecast. |
It sounds reasonable as a feature. I'm not sure if we could justify getting rid of mux.js support altogether, but extending the CEA-608 parser to not require the intermediary step of turning TS into MP4 would be nice performance-wise. I don't think this is something the Google Cast team is interested in, though, so I wouldn't expect us to get around to it anytime soon. I'll mark this as seeking PRs for now. |
@theodab Do you know if the Cast team wants only DASH or is also interested in migrating and using ShakaPlayer for HLS as well? |
We would like to use Shaka for HLS, and TS in HLS isn't going away any time soon. (Though it saddens me to admit it.) So yes, we should extend the CEA parser to support TS and drop this flag. |
Looking at this again, forceTransmuxTS isn't only useful for CEA. It's also useful for working around broken platforms. So long as we have transmuxing with mux.js, I think we should give apps the option to force us to transmux TS, even when the platform claims to support it. But I'm still in favor of using our native CEA parser for TS as soon as we can. |
Closes #3674 Co-authored-by: Joey Parrish <joeyparrish@google.com>
Closes shaka-project#3674 Co-authored-by: Joey Parrish <joeyparrish@google.com>
Have you read the FAQ and checked for duplicate open issues? YES
Is your feature request related to a problem? Please describe.
Right now there is the forceTransmuxTS setting to parse CEA-608 on devices that natively support TS, but this involves using mux.js and transmuxing TS to MP4.
Describe the solution you'd like
Since we have a CEA-608 parser for MP4, the idea would be to extend it to support TS.
Describe alternatives you've considered
Leave current behavior
The text was updated successfully, but these errors were encountered: