Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cea): Add CEA parser for TS #4697

Merged
merged 20 commits into from
Nov 28, 2022
Merged

feat(cea): Add CEA parser for TS #4697

merged 20 commits into from
Nov 28, 2022

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Nov 11, 2022

Closes #3674

@avelad avelad marked this pull request as draft November 11, 2022 22:18
@avelad avelad added type: enhancement New feature or request component: captions/subtitles The issue involves captions or subtitles priority: P3 Useful but not urgent labels Nov 11, 2022
@avelad avelad added this to the v4.4 milestone Nov 11, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022 •
edited

Incremental code coverage: 97.52%

@avelad avelad force-pushed the ts-cea-parser branch 2 times, most recently from 5fc363d to fa1276f Compare November 12, 2022 11:15
@avelad avelad marked this pull request as ready for review November 15, 2022 18:46
joeyparrish
joeyparrish requested changes Nov 17, 2022
View reviewed changes
lib/media/media_source_engine.js Show resolved Hide resolved
lib/cea/ts_cea_parser.js Outdated Show resolved Hide resolved
lib/util/ts_parser.js Outdated Show resolved Hide resolved
lib/util/ts_parser.js Outdated Show resolved Hide resolved
lib/util/ts_parser.js Outdated Show resolved Hide resolved
joeyparrish
joeyparrish requested changes Nov 19, 2022
View reviewed changes
lib/util/ts_parser.js Outdated Show resolved Hide resolved
lib/util/ts_parser.js Outdated Show resolved Hide resolved
joeyparrish added a commit to joeyparrish/shaka-player that referenced this pull request Nov 21, 2022
@joeyparrish
test: Expand CEA test expectations
12083e2 
Related to PR shaka-project#4697
@joeyparrish joeyparrish mentioned this pull request Nov 21, 2022
Merged
avelad pushed a commit that referenced this pull request Nov 21, 2022
@joeyparrish
test: Expand CEA test expectations (#4735)
1986016 
Related to PR #4697

This will help us ensure we're not changing parsing outputs by accident.
@avelad
Merge branch 'main' into ts-cea-parser
c4a5666 
# Conflicts:
#	test/media/media_source_engine_integration.js
joeyparrish added a commit to joeyparrish/shaka-player that referenced this pull request Nov 22, 2022
@joeyparrish
test: Finish TS StreamGenerator
6941242 
This completes the TS StreamGenerator and updates test expectations to
match.  With this, we get realistic simulated TS streams, which will
be important as a baseline for replacing mux.js with our own TS
parser.

See also PR shaka-project#4697
@joeyparrish
test: Finish TS StreamGenerator
dd7ed41 
This completes the TS StreamGenerator and updates test expectations to
match.  With this, we get realistic simulated TS streams, which will
be important as a baseline for replacing mux.js with our own TS
parser.

See also PR shaka-project#4697
@joeyparrish joeyparrish mentioned this pull request Nov 22, 2022
Merged
@joeyparrish
Copy link
Member

Includes #4739, but still isn't quite passing tests. I fixed two edge cases (one in TS parser, one in CEA decoder) that got the new parser's output aligned on timestamps... but I'm still seeing one edge case left.

In the test where we append segment 0 only, we see the first cue come in at time 0.067 - 0.734, but when we append segment 2, then segment 0, that same cue for segment 0 comes in at time 0.767 - 4.972 (which is the same time as the old parser output).

@joeyparrish
Copy link
Member

This exercise led to some bugs discovered, and the new test coverage shows that my changes to clarify the NALU parser did not break anything.

avelad pushed a commit that referenced this pull request Nov 22, 2022
@joeyparrish
test: Finish TS StreamGenerator (#4739)
f904583 
This completes the TS StreamGenerator and updates test expectations to
match. With this, we get realistic simulated TS streams, which will be
important as a baseline for replacing mux.js with our own TS parser.

See also PR #4697
@avelad
Copy link
Collaborator Author

avelad commented Nov 22, 2022 •
edited

Includes #4739, but still isn't quite passing tests. I fixed two edge cases (one in TS parser, one in CEA decoder) that got the new parser's output aligned on timestamps... but I'm still seeing one edge case left.

In the test where we append segment 0 only, we see the first cue come in at time 0.067 - 0.734, but when we append segment 2, then segment 0, that same cue for segment 0 comes in at time 0.767 - 4.972 (which is the same time as the old parser output).

So the problem is just when the first segment is added and with the first timestampOffset. After investigating the problem is in our CEA parser, I will continue investigating.

@avelad avelad merged commit 70fad8d into shaka-project:main Nov 28, 2022
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Merged
@avelad avelad deleted the ts-cea-parser branch November 28, 2022 19:46
joeyparrish added a commit that referenced this pull request Dec 8, 2022
@joeyparrish
test: Expand CEA test expectations (#4735)
1ef2a33 
Related to PR #4697

This will help us ensure we're not changing parsing outputs by accident.
joeyparrish added a commit that referenced this pull request Dec 8, 2022
@joeyparrish
test: Finish TS StreamGenerator (#4739)
96d5283 
This completes the TS StreamGenerator and updates test expectations to
match. With this, we get realistic simulated TS streams, which will be
important as a baseline for replacing mux.js with our own TS parser.

See also PR #4697
joeyparrish added a commit that referenced this pull request Dec 8, 2022
@joeyparrish
test: Expand CEA test expectations (#4735)
28c2769 
Related to PR #4697

This will help us ensure we're not changing parsing outputs by accident.
joeyparrish added a commit that referenced this pull request Dec 8, 2022
@joeyparrish
test: Finish TS StreamGenerator (#4739)
6df6e64 
This completes the TS StreamGenerator and updates test expectations to
match. With this, we get realistic simulated TS streams, which will be
important as a baseline for replacing mux.js with our own TS parser.

See also PR #4697
swac pushed a commit to loomhq/shaka-player that referenced this pull request Feb 9, 2023
@avelad @joeyparrish @swac
feat(cea): Add CEA parser for TS (shaka-project#4697)
83714b0 
Closes shaka-project#3674

Co-authored-by: Joey Parrish <joeyparrish@google.com>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

Use Shaka CEA parser for TS
2 participants
@avelad @joeyparrish