-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tick timer keeps running after calling destroy #4850
Labels
priority: P1
Big impact or workaround impractical; resolve before feature release
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
avelad
added
the
priority: P1
Big impact or workaround impractical; resolve before feature release
label
Jan 3, 2023
Looks like we aren't releasing |
theodab
added a commit
to theodab/shaka-player
that referenced
this issue
Jan 6, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes shaka-project#4850
theodab
added a commit
that referenced
this issue
Jan 7, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes #4850
theodab
added a commit
to theodab/shaka-player
that referenced
this issue
Jan 8, 2023
joeyparrish
pushed a commit
that referenced
this issue
Jan 10, 2023
joeyparrish
pushed a commit
that referenced
this issue
Jan 13, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes #4850
joeyparrish
pushed a commit
that referenced
this issue
Jan 13, 2023
joeyparrish
pushed a commit
that referenced
this issue
Jan 13, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes #4850
joeyparrish
pushed a commit
that referenced
this issue
Jan 13, 2023
joeyparrish
pushed a commit
that referenced
this issue
Jan 13, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes #4850
joeyparrish
pushed a commit
that referenced
this issue
Jan 13, 2023
joeyparrish
pushed a commit
that referenced
this issue
Jan 13, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes #4850
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this issue
Feb 8, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes shaka-project#4850
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this issue
Feb 8, 2023
github-actions
bot
added
the
status: archived
Archived and locked; will not be updated
label
Mar 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
priority: P1
Big impact or workaround impractical; resolve before feature release
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.3.2
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Did not try
Are you using the demo app or your own custom app?
Custom
If custom app, can you reproduce the issue using our demo app?
Did not check
What browser and OS are you using?
Mac/Chrome
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
What are the manifest and license server URIs?
What configuration are you using? What is the output of
player.getConfiguration()
?Default
What did you do?
Start the playback. Stop (destroy).
added a snippet to print which timers are running -
window.setTimeoutOriginal = window.setTimeout; window.setTimeout = (func, delay) => {console.log("setTimeout", func); return window.setTimeoutOriginal(func, delay)}
What did you expect to happen?
Player should stop executing
What actually happened?
There is a tick timer that runs continuously. Screenshot is after destroy.
The text was updated successfully, but these errors were encountered: