Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tick timer keeps running after calling destroy #4850

Closed
kiran-dcunha opened this issue Dec 20, 2022 · 1 comment · Fixed by #4871
Closed

Tick timer keeps running after calling destroy #4850

kiran-dcunha opened this issue Dec 20, 2022 · 1 comment · Fixed by #4871
Assignees
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@kiran-dcunha
Copy link

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
4.3.2

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Did not try

Are you using the demo app or your own custom app?
Custom

If custom app, can you reproduce the issue using our demo app?
Did not check

What browser and OS are you using?
Mac/Chrome

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

Start the playback. Stop (destroy).

added a snippet to print which timers are running -
window.setTimeoutOriginal = window.setTimeout; window.setTimeout = (func, delay) => {console.log("setTimeout", func); return window.setTimeoutOriginal(func, delay)}

What did you expect to happen?
Player should stop executing

What actually happened?

There is a tick timer that runs continuously. Screenshot is after destroy.
image

@kiran-dcunha kiran-dcunha added the type: bug Something isn't working correctly label Dec 20, 2022
@github-actions github-actions bot added this to the v4.4 milestone Dec 20, 2022
@avelad avelad added the priority: P1 Big impact or workaround impractical; resolve before feature release label Jan 3, 2023
@theodab
Copy link
Collaborator

theodab commented Jan 6, 2023

Looks like we aren't releasing shaka.media.RegionTimeline when we destroy the player, and that class has a timer in it.

@theodab theodab self-assigned this Jan 6, 2023
theodab added a commit to theodab/shaka-player that referenced this issue Jan 6, 2023
This stops the timer inside region timeline from staying in memory,
even after the player is destroyed.

Closes shaka-project#4850
theodab added a commit that referenced this issue Jan 7, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed.

Closes #4850
theodab added a commit to theodab/shaka-player that referenced this issue Jan 8, 2023
joeyparrish pushed a commit that referenced this issue Jan 13, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed.

Closes #4850
joeyparrish pushed a commit that referenced this issue Jan 13, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed.

Closes #4850
joeyparrish pushed a commit that referenced this issue Jan 13, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed.

Closes #4850
joeyparrish pushed a commit that referenced this issue Jan 13, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed.

Closes #4850
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Feb 8, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed.

Closes shaka-project#4850
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Feb 8, 2023
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Mar 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants