fix: Release region timeline when unloading #4871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes shaka-project#4850
theodab
added
type: bug
|
I spent way too long trying to make a good, future-proof integration test that would detect if we had any other timers endlessly firing off after destroying the player. |
|
Incremental code coverage: 100.00% |
avelad
approved these changes
Jan 6, 2023
joeyparrish
approved these changes
Jan 6, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Jan 13, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes #4850
joeyparrish
pushed a commit
that referenced
this pull request
Jan 13, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes #4850
joeyparrish
pushed a commit
that referenced
this pull request
Jan 13, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes #4850
joeyparrish
pushed a commit
that referenced
this pull request
Jan 13, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes #4850
Robloche
pushed a commit
to Robloche/shaka-player
that referenced
this pull request
Feb 8, 2023
This stops the timer inside region timeline from staying in memory, even after the player is destroyed. Closes shaka-project#4850
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops the timer inside region timeline from staying in memory, even after the player is destroyed.
Closes #4850