Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates the IMA sdk ads rendering settings #5011

Closed
rizalibnu opened this issue Feb 17, 2023 · 0 comments · Fixed by #5536
Closed

Updates the IMA sdk ads rendering settings #5011

rizalibnu opened this issue Feb 17, 2023 · 0 comments · Fixed by #5536
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v4.4

Comments

@rizalibnu
Copy link

Have you read the Tutorials?
Yes

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
4.3.4

Please ask your question
Hi, is there a way to updates the IMA sdk ads rendering settings? I want to set restoreCustomPlaybackStateOnAdBreakComplete to be true

https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/reference/js/google.ima.AdsManager#updateAdsRenderingSettings

https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/reference/js/google.ima.AdsRenderingSettings#restoreCustomPlaybackStateOnAdBreakComplete
@rizalibnu rizalibnu added the type: question A question from the community label Feb 17, 2023
@avelad avelad added the component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs label Feb 21, 2023
@rizalibnu rizalibnu mentioned this issue Feb 24, 2023
Closed
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent and removed type: question A question from the community labels Feb 24, 2023
@github-actions github-actions bot added this to the Backlog milestone Feb 24, 2023
@avelad avelad mentioned this issue Aug 25, 2023
Merged
@avelad avelad modified the milestones: Backlog, v4.4 Aug 25, 2023
avelad added a commit that referenced this issue Aug 25, 2023
@avelad
feat(Ads): Add control AdsRenderingSettings (#5536)
d37143e 
Closes #5011
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 24, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 24, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
feat(Ads): Add control AdsRenderingSettings (shaka-project#5536)
657ca93 
Closes shaka-project#5011
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.4
3 participants
@avelad @shaka-bot @rizalibnu