Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Ads): Add control AdsRenderingSettings #5536

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Aug 25, 2023

Closes #5011

@avelad avelad added type: enhancement New feature or request component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent labels Aug 25, 2023
@avelad avelad added this to the v4.4 milestone Aug 25, 2023
@github-actions
Copy link
Contributor

Incremental code coverage: No instrumented code was changed.

@avelad avelad merged commit d37143e into shaka-project:main Aug 25, 2023
21 checks passed
@avelad avelad deleted the ads-rendering-settings branch August 25, 2023 10:41
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Oct 24, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates the IMA sdk ads rendering settings
3 participants