fix(WebVTT): Fix support for line:0 vertical alignment #5632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
avelad
force-pushed
the
subtitle-line-0
branch
from
9cb37ac
to
5628041
Compare
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
|
Incremental code coverage: 100.00% |
theodab
requested changes
Sep 12, 2023
lib/text/ui_text_displayer.js
Outdated
| // safely. | ||
| if (cue.line == 0 && | ||
| cue.lineInterpretation == Cue.lineInterpretation.LINE_NUMBER) { | ||
| cue.lineInterpretation = Cue.lineInterpretation.PERCENTAGE; |
There was a problem hiding this comment.
It's not technically listed in the interface or anything, but up until now the process of appending cues has not caused the actual cue objects to be mutated.
I think it'd be better to make a local variable for lineInterpretation and change that, here.
theodab
approved these changes
Sep 12, 2023
|
@shaka-bot test |
|
@avelad: Lab tests started with arguments:
|
joeyparrish
pushed a commit
that referenced
this pull request
Sep 13, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Sep 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4446