-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(WebVTT): Fix support for line:0 vertical alignment #5632
Conversation
9cb37ac
to
5628041
Compare
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
Incremental code coverage: 100.00% |
lib/text/ui_text_displayer.js
Outdated
// safely. | ||
if (cue.line == 0 && | ||
cue.lineInterpretation == Cue.lineInterpretation.LINE_NUMBER) { | ||
cue.lineInterpretation = Cue.lineInterpretation.PERCENTAGE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not technically listed in the interface or anything, but up until now the process of appending cues has not caused the actual cue objects to be mutated.
I think it'd be better to make a local variable for lineInterpretation
and change that, here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed!
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
Related to #4446