Exception in UITextDisplayer constructor #6531
Assignees
Labels
component: captions/subtitles
The issue involves captions or subtitles
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
Comments
MichaelSweden
added a commit
to MichaelSweden/shaka-player
that referenced
this issue
May 4, 2024
Keep constructor backward compatible with earlier that had two arguments, i.e. make the new third optional for existing applications. Fixes shaka-project#6531
avelad
added
priority: P2
avelad
added a commit
that referenced
this issue
May 6, 2024
Keep constructor backward compatible with earlier that had two arguments, i.e. make the new third optional for existing applications. Fixes #6531 --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
avelad
added a commit
that referenced
this issue
May 6, 2024
Keep constructor backward compatible with earlier that had two arguments, i.e. make the new third optional for existing applications. Fixes #6531 --------- Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Have you read the FAQ and checked for duplicate open issues?
Yes
If the problem is related to FairPlay, have you read the tutorial?
Not related.
What version of Shaka Player are you using?
v4.8.1
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main?Yes
Are you using the demo app or your own custom app?
Own application.
If custom app, can you reproduce the issue using our demo app?
No
What browser and OS are you using?
Chromium Xubuntu, and Cobalt.
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Not applicable.
What are the manifest and license server URIs?
Not relevant.
What configuration are you using? What is the output of
player.getConfiguration()?Not relevant.
What did you do?
Start playback.
What did you expect to happen?
Video playing
What actually happened?
No video and no logs from Shaka. Seems to stop/hang after "media-source" state change. Problem tracked down to when the application creates a new UITextDisplayer, at the timer part in its constructor.
The problem was introduced by this commit: de2a2d8 feat: Add TextDisplayer config (#6477)
This added a possibility to set caption update period via a new config argument. However it is implemented in a mandatory way, no backward compatibility with existing applications.
PS. Pull request on the way.
The text was updated successfully, but these errors were encountered: