-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webOS 4032 error in compiled version but not debug version #6533
Comments
We do not have a WebOS device to test, if you identify the PR that includes the regression, we can try to find the problem. Thank you! |
Noted @avelad it is a bit tricky due to the nature of the issue. |
We have the same issue: 4032 with compiled version on webOS, but ok on Tizen and with debug version on webOS. |
Since it happens to many people, anyone who wants to contribute to fixing it, please do, we don't have WebOS in the lab to test. Thank you very much to all! |
This issue is a bit of a needle in a haystack. |
Since it only happens in WebOS I don't know what to say... |
Since almost all bufixes are ported to other branches, the ideal would be to start with features: https://github.com/shaka-project/shaka-player/releases/tag/v4.8.0 |
Seems to be occurring around the preload area maybe related to |
|
Looking more into: feat: Add preload system to player #5897 |
Hopefully create a PR tomorrow. |
@stuartflanagan can you review if #6180 introduce any error? Thanks! |
Hi @avelad.
I do not think this is a webOS issue but is potentially a compiler issue with |
Ah, I see. JSON.parse returns the correct thing in every mode, but the compiler sees the type as something it can minify. So the compiled version would be something like: const a = JSON.parse(window.PalmSystem.deviceInfo);
const b = a.b;
const c = a.c; The solution is to move the parsed type to the externs or to use |
Thanks @joeyparrish that seems a lot easier than the REGEX I have just created to parse the deviceInfo 🤣 |
Any chance this fix could go into an earlier release than 4.9? |
Once the PR is merged it, I'll release 4.8.3 asap. |
Fixes #6533 The original author is: @stuartflanagan The original PR is: #6554
Fixes #6533 The original author is: @stuartflanagan The original PR is: #6554
@avelad & @joeyparrish I just had a question regarding this issue. |
Sorry to comment on this closed issue. Should I create // WebOS has always been able to do 1080p. Assume a 1080p limit.
// Set reasonable defaults in case an issue occurs
maxResolution.width = 1920;
maxResolution.height = 1080;
try {
const deviceInfo =
/** @type {{screenWidth: number, screenHeight: number}} */(
JSON.parse(window.PalmSystem.deviceInfo));
// WebOS has always been able to do 1080p. Assume a 1080p limit.
const screenWidth = deviceInfo['screenWidth'];
const screenHeight = deviceInfo['screenHeight'];
if(!isNaN(screenWidth) && !isNaN(screenHeight)){
maxResolution.width = screenWidth;
maxResolution.height = screenHeight;
}
} catch (e) {
shaka.log.alwaysWarn('WebOS: Error detecting screen size, default ' +
'screen size 1920x1080.');
} Hisense also has 720 devices too. |
Sorry, I don't think it's correct in the case of WebOS, looking at the specifications all versions since WebOS 3.0 support a minimum of 1080p: https://webostv.developer.lge.com/develop/specifications/video-audio-30 |
I can't say anything about the Hisense case, because I can't test it right now and I don't have access to its documentation, but I think it's the same case with WebOS. This is normally due (at least in Europe), because even if the TV is 720, the broadcast broadcasts can be at 1080 and have to support them. |
Thank you for all your help with this @avelad! |
Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
4.8.x
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Yes
Are you using the demo app or your own custom app?
Both
If custom app, can you reproduce the issue using our demo app?
Yes
What browser and OS are you using?
LG webOS
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
webOS3-2024
What are the manifest and license server URIs?
webOS is returning 4032 for manifest media types
HLS: https://demo.unified-streaming.com/k8s/features/stable/usp-s3-storage/tears-of-steel/tears-of-steel.ism/.m3u8
MPD: https://storage.googleapis.com/shaka-demo-assets/angel-one/dash.mpd
What configuration are you using? What is the output of
player.getConfiguration()
?Default
What did you do?
Attempted to playback DASH and HLS manifest
What did you expect to happen?
Playback to occur
What actually happened?
Playback results in startup error with code 4032.
When switching to
debug
playershaka-player.compiled.debug.js
Playback is fine and error is not reported.
Playback for any stream type is failing for all webOS devices using the compiled version of Shaka Player 4.8 +
When attempting to debug the issue with the debug version the error is no longer there and playback is as expected.
The text was updated successfully, but these errors were encountered: