-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Issue with compiler minifying webOS device properties #6558
Conversation
Incremental code coverage: 0.00% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thank you @avelad
Fixes #6533 The original author is: @stuartflanagan The original PR is: #6554
@@ -684,8 +684,8 @@ shaka.util.Platform = class { | |||
/** @type {{screenWidth: number, screenHeight: number}} */( | |||
JSON.parse(window.PalmSystem.deviceInfo)); | |||
// WebOS has always been able to do 1080p. Assume a 1080p limit. | |||
maxResolution.width = Math.max(1920, deviceInfo.screenWidth); | |||
maxResolution.height = Math.max(1080, deviceInfo.screenHeight); | |||
maxResolution.width = Math.max(1920, deviceInfo['screenWidth']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😮 Can someone explain why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See: #6533 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks...
Fixes #6533
The original author is: @stuartflanagan
The original PR is: #6554