Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fullscreen polyfill lacks for fullscreenEnabled property #669

Closed
sgrogov opened this issue Jan 27, 2017 · 2 comments
Closed

Fullscreen polyfill lacks for fullscreenEnabled property #669

sgrogov opened this issue Jan 27, 2017 · 2 comments
Assignees
@theodab
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request

Comments

@sgrogov
Copy link

sgrogov commented Jan 27, 2017

Is there any reason that fullscreenEnabled ignored in shaka.polyfill.Fullscreen?
MDN describes it on a par with requestFullscreen and other properties, so i guess that support of this property is required. Although fullscreenEnabled not used in the shaka library, this may lead to unexpected behaviour.
@joeyparrish joeyparrish added flag: good first issue This might be a relatively easy issue; good for new contributors type: enhancement New feature or request labels Jan 30, 2017
@joeyparrish
Copy link
Member

This was an oversight on our part. It has been fixed in master, and I will cherry-pick it to v2.0.x. You should see the fix in our upcoming v2.0.6 release. Thanks!

joeyparrish pushed a commit that referenced this issue Feb 10, 2017
@theodab @joeyparrish
Expanded the fullscreen polyfill.
6f3e256 
Now it includes fullscreenEnabled.

Closes #669

Change-Id: I7df3c422ecc72215a48ba72ac57aae2bc9b600d5
@sgrogov
Copy link
Author

sgrogov commented Feb 11, 2017

Thank you, Joey!

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@theodab theodab

Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joeyparrish @sgrogov @shaka-bot @theodab