Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getStats().switchHistory is not returning variant tracks ids #785

Closed
hussam-i-am opened this issue May 5, 2017 · 6 comments
Closed

getStats().switchHistory is not returning variant tracks ids #785

hussam-i-am opened this issue May 5, 2017 · 6 comments
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@hussam-i-am
Copy link

  • What version of Shaka Player are you using? 2.1.0
    • Can you reproduce the issue with our latest release version? Yes
    • Can you reproduce the issue with the latest code from master? Yes
  • Are you using the demo app or your own custom app? Both
    • If custom app, can you reproduce the issue using our demo app? Yes
  • What browser and OS are you using? MacOS/Chrome
  • What did you do? Called player.getStats().switchHistory`
    • What content did you load? Angel One demo asset
    • How did you interact with the content, if at all? Loaded demo asset
  • What did you expect to happen? According to the documentation, When accessing switchHistory, it should return a StreamChoice with either a variant or text type
  • What actually happened? StreamChoice is still returning the old format with types video and audio, with ids not matching the ids of the chosen variant tracks
@TheModMaker TheModMaker added type: bug Something isn't working correctly flag: good first issue This might be a relatively easy issue; good for new contributors labels May 5, 2017
@TheModMaker TheModMaker added this to the v2.2.0 milestone May 5, 2017
@hussam-i-am
Copy link
Author

hussam-i-am commented May 9, 2017

Since this is marked at v2.2.0, I'd be happy to fork and create a fix, if it can be cherry picked for the next release. I looked over the code that adds the audio and video tracks to the history, is there anything that I should be aware of?

@joeyparrish
Copy link
Member

Yes, I would be happy to take a PR for this. I would also be glad to cherry-pick the fix to v2.1.x.

@joeyparrish joeyparrish removed the flag: good first issue This might be a relatively easy issue; good for new contributors label May 24, 2017
@joeyparrish
Copy link
Member

I looked into this a little as part of #823, which overlaps a lot. Here's what I found:

  • Track ID for variants is taken from Variant ID
  • Track ID for text is taken from Stream ID
  • Stream and Variant IDs are auto-incremented integers, not from manifest
  • switchHistory contains Stream IDs only

The crux of the problem is that variant Tracks have the Variant ID, but the two Streams inside the Variant have their own IDs which are only seen in switchHistory and can't be correlated to anything through the public API.

@joeyparrish
Copy link
Member

Changing switchHistory to contain variant changes instead of individual audio/video streams would probably suffice.

@hussam-i-am
Copy link
Author

hussam-i-am commented May 24, 2017 via email

@joeyparrish
Copy link
Member

Cherry-picked to v2.1.3.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

4 participants