Audio and video stream ID in variant tracks #843
Conversation
externs/shaka/player.js
Outdated
| @@ -190,6 +192,10 @@ shakaExtern.Stats; | |||
| * cannot be satisfied. | |||
| * @property {!Array.<string>} roles | |||
| * The roles of the track, e.g. 'main', 'caption', or 'commentary'. | |||
| * @property {?number} videoId | |||
| * (only for variant tracks) The video track id. | |||
There was a problem hiding this comment.
Nitpick: please change to video STREAM id (instead of track).
A track is a representation of a variant or text stream, so technically we don't have video/audio tracks.
Same for audio below. The rest of the CL looks good to me.
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Can you rebase your changes? |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
Sorry, im forget to rebase. Forget/cancel this PR and ill do it another. |
|
Okay. Whatever works best for you. Thanks for contributing! I'll keep an eye out for the next PR. |
github-actions
bot
added
the
status: archived
Add video and audio stream IDs for
getStats().switchHistoryRelated to #823, #785