Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo: "this.playerInterface_.filterAllPeriods is not a function" error #988

Closed
beaufortfrancois opened this issue Aug 24, 2017 · 9 comments
Closed

Demo: "this.playerInterface_.filterAllPeriods is not a function" error #988

beaufortfrancois opened this issue Aug 24, 2017 · 9 comments
Assignees
@joeyparrish
Labels
flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v2.3.0

Comments

@beaufortfrancois
Copy link
Contributor

Steps to reproduce:

  1. Go to https://shaka-player-demo.appspot.com/demo/#asset=//storage.googleapis.com/shaka-demo-assets/angel-one-widevine/dash.mpd;lang=en-US
  2. Click "Load" button
  3. Scroll down, Expand "Offline" and click "Store" button
  4. Error message "this.playerInterface_.filterAllPeriods is not a function" shows up

Platform: Google Chrome 62.0.3194.0 - Android O
@ismena
Copy link
Contributor

ismena commented Aug 24, 2017

Hi, do you mind realoading the page/clearing browser cache and trying again? This looks like a caching issue we've been having after deployment of 2.2, but it should be resolved now.
I also see that you were the one to open #985. Are you still seeing this although the issue from 985 has been resoled? (You left a comment there that made me assume it was working for you now :)).

@beaufortfrancois
Copy link
Contributor Author

I've reset site setttings and I can still reproduce.
#985 works great now!

@joeyparrish
Copy link
Member

Confirmed, even with the clear version of that asset. Thanks!

@joeyparrish joeyparrish added this to the v2.3.0 milestone Aug 24, 2017
@joeyparrish joeyparrish added the type: bug Something isn't working correctly label Aug 24, 2017
@joeyparrish joeyparrish self-assigned this Aug 24, 2017
@joeyparrish
Copy link
Member

The bug seems to be in shaka.offline.Storage, but it isn't caught in the integration tests. The issue is in the interface between the manifest parser and Storage, and our integration tests use fake manifests. The filtering functionality is therefore not covered in these tests.

@joeyparrish joeyparrish added the flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue label Aug 24, 2017
@joeyparrish
Copy link
Member

The fix will be in the nightly build tomorrow, and in v2.2.1 after that. Thanks!

@beaufortfrancois
Copy link
Contributor Author

Where can I access the nightly build?

@avelad
Copy link
Collaborator

avelad commented Aug 28, 2017

@beaufortfrancois You can access to nightly build in: https://nightly-dot-shaka-player-demo.appspot.com/demo/

@beaufortfrancois
Copy link
Contributor Author

I can no longer reproduce the issue.
Thank you @joeyparrish and @avelad.

joeyparrish added a commit that referenced this issue Aug 31, 2017
@joeyparrish
Fix filtering in offline storage
b0d6275 
The offline storage system did not completely implement the interface
used by the manifest parsers.  This fixes the interface and makes sure
that existing tests will cover the use of this interface.

Closes #988

Change-Id: Ib8ccae56b144edbfdc9d3fcd865924faf620eb44
@joeyparrish
Copy link
Member

Cherry-picked to v2.2.1

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
flag: Why didn't we catch this sooner This issue is embarassing; we may still need an automated test that could have prevented this issue status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v2.3.0
Development

No branches or pull requests
5 participants
@beaufortfrancois @ismena @joeyparrish @avelad @shaka-bot