Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer unprefixed EME for Safari #3021

Merged
merged 3 commits into from
Jan 19, 2021
Merged

Prefer unprefixed EME for Safari #3021

merged 3 commits into from
Jan 19, 2021

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Dec 3, 2020

Closes: #2999

@avelad avelad mentioned this pull request Dec 3, 2020
Closed
@joeyparrish joeyparrish mentioned this pull request Jan 19, 2021
Closed
@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 42d9ec0 into shaka-project:master Jan 19, 2021
@avelad avelad deleted the unprefixed-eme-safari branch January 20, 2021 06:52
joeyparrish pushed a commit that referenced this pull request Jan 25, 2021
@joeyparrish
Prefer unprefixed EME for Safari (#3021)
4e17129 
Closes: #2999
@avelad
Copy link
Collaborator Author

avelad commented Jan 25, 2021

@joeyparrish I found a bug with AES-128 that was previously working and it can break many applications. Please don't cherry-pick it to v3.0.x please!!

@joeyparrish
Copy link
Member

I just pushed it to v3.0.x this morning, but we haven't made a release yet. Would you like me to revert it in the v3.0.x branch? What about the master branch?

@avelad
Copy link
Collaborator Author

avelad commented Jan 25, 2021

Yes, I want you to revert it from 3.0.x. For the master we have two options: revert it (and later I will do a PR with the fix and the change) or leave it while I find a solution

@joeyparrish
Copy link
Member

Since there are other, good changes in this PR, to minimize what you have to do to re-enable it, I will make a small change in the polyfill to continue preferring prefixed EME. I'll get this reviewed and into both branches. I'll also reopen the corresponding issue. You can follow-up with a fix and re-enable unprefixed at the polyfill at a later date. Sound good?

@avelad
Copy link
Collaborator Author

avelad commented Jan 25, 2021

Perfect! Thanks @joeyparrish !

shaka-bot pushed a commit that referenced this pull request Jan 25, 2021
@joeyparrish
fix: Disable unprefixed EME on Safari
dd94bd3 
@avelad reported that PR #3021 caused a regression.  Rather than
revert the entire thing, we are disabling one part of that change to
make it easier to re-enable once the issue is fixed.  We will also
reopen issue #2999 until this is resolved.

Change-Id: I65d93da903d90668bb19e5248658eb458e8bb5c4
joeyparrish added a commit that referenced this pull request Jan 25, 2021
@joeyparrish
fix: Disable unprefixed EME on Safari
66cdd44 
@avelad reported that PR #3021 caused a regression.  Rather than
revert the entire thing, we are disabling one part of that change to
make it easier to re-enable once the issue is fixed.  We will also
reopen issue #2999 until this is resolved.

Change-Id: I65d93da903d90668bb19e5248658eb458e8bb5c4
@joeyparrish
Copy link
Member

Unprefixed EME is now disabled in both branches. Thanks!

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@valotvince valotvince valotvince left review comments

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefer unprefixed EME for Safari
4 participants
@avelad @shaka-bot @joeyparrish @valotvince