Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix registerScheme snippet #5635

Merged
merged 1 commit into from
Sep 11, 2023
Merged

docs: Fix registerScheme snippet #5635

merged 1 commit into from
Sep 11, 2023

Conversation

loicraux
Copy link
Contributor

Fixes #5634

@google-cla
Copy link

google-cla bot commented Sep 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@joeyparrish joeyparrish changed the title fix(faq): A parse func is passed to registerScheme docs: Fix registerScheme snippet Sep 11, 2023
@joeyparrish joeyparrish merged commit df2739e into shaka-project:main Sep 11, 2023
3 checks passed
@loicraux loicraux deleted the fix-unsupported-scheme-faq-entry branch September 11, 2023 18:29
joeyparrish pushed a commit that referenced this pull request Sep 13, 2023
Fixes #5634

Co-authored-by: Loïc Raux <loicraux@gmail.com>
joeyparrish pushed a commit that referenced this pull request Sep 13, 2023
Fixes #5634

Co-authored-by: Loïc Raux <loicraux@gmail.com>
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 10, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Response to a question in FAQ.md is wrong
3 participants