Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Response to a question in FAQ.md is wrong #5634

Closed
loicraux opened this issue Sep 11, 2023 · 2 comments · Fixed by #5635
Closed

[docs] Response to a question in FAQ.md is wrong #5634

loicraux opened this issue Sep 11, 2023 · 2 comments · Fixed by #5635
Assignees
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation
Milestone

Comments

@loicraux
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?

yes, the issue lies precisely in the FAQ itself :)

If the problem is related to FairPlay, have you read the tutorial?

N/A

What version of Shaka Player are you using?

N/A

Can you reproduce the issue with our latest release version?

yes

Can you reproduce the issue with the latest code from main?

yes

Are you using the demo app or your own custom app?

N/A

If custom app, can you reproduce the issue using our demo app?

N/A

What browser and OS are you using?

N/A

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

N/A

What are the manifest and license server URIs?

N/A

What configuration are you using? What is the output of player.getConfiguration()?

N/A

What did you do?

On the FAQ page, the answer to the question Q: I am getting UNSUPPORTED_SCHEME or error code 1000 when loading from file://. is the following :

A: In a browser environment, trying to load a file from file:// is inappropriate. Therefore, we do not provide a default network plugin for such requests.

In other environments, for example Electron, it is appropriate. In those cases, before Shaka Player loads a manifest, you can register the existing http plugin for file:// requests:

shaka.net.NetworkingEngine.registerScheme('file', shaka.net.HttpXHRPlugin);

What did you expect to happen?
What actually happened?

The correct answer is the following :

shaka.net.NetworkingEngine.registerScheme('file', shaka.net.HttpXHRPlugin.parse); // <-- note the .parse
@loicraux loicraux added the type: bug Something isn't working correctly label Sep 11, 2023
@joeyparrish
Copy link
Member

PRs are always welcome!

@joeyparrish joeyparrish added type: docs Improvements or fixes to documentation priority: P3 Useful but not urgent and removed type: bug Something isn't working correctly labels Sep 11, 2023
@shaka-bot shaka-bot added this to the v4.5 milestone Sep 11, 2023
@loicraux
Copy link
Contributor Author

OK I'll create a PR for this one :)

joeyparrish pushed a commit that referenced this issue Sep 11, 2023
Fixes #5634

Co-authored-by: Loïc Raux <loicraux@gmail.com>
joeyparrish pushed a commit that referenced this issue Sep 13, 2023
Fixes #5634

Co-authored-by: Loïc Raux <loicraux@gmail.com>
joeyparrish pushed a commit that referenced this issue Sep 13, 2023
Fixes #5634

Co-authored-by: Loïc Raux <loicraux@gmail.com>
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 10, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 10, 2023
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
Fixes shaka-project#5634

Co-authored-by: Loïc Raux <loicraux@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: docs Improvements or fixes to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants