Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Unfork less.js #6268

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

joeyparrish
Copy link
Member

The issue we had in less.js v4 has since been resolved. This updates to less.js v4.2.0, which includes the underlying fix from its dependency, needle v3.1.0.

Unforking also resolves CI issues where gitpkg.now.sh temporarily fails to load, causing the whole test run to fail before it can start.

@joeyparrish joeyparrish marked this pull request as ready for review February 21, 2024 19:37
@joeyparrish
Copy link
Member Author

Verified that less.js doesn't break on Mac (the issue that caused us to fork originally.)

@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

The issue we had in less.js v4 has since been resolved.  This updates
to less.js v4.2.0, which includes the underlying fix from its
dependency, needle v3.1.0.

Unforking also resolves CI issues where gitpkg.now.sh temporarily
fails to load, causing the whole test run to fail before it can start.
@joeyparrish joeyparrish merged commit ddc2499 into shaka-project:main Feb 21, 2024
12 of 15 checks passed
@joeyparrish joeyparrish deleted the unfork-lessjs branch February 21, 2024 21:25
joeyparrish added a commit that referenced this pull request Feb 26, 2024
The issue we had in less.js v4 has since been resolved. This updates to
less.js v4.2.0, which includes the underlying fix from its dependency,
needle v3.1.0.

Unforking also resolves CI issues where gitpkg.now.sh temporarily fails
to load, causing the whole test run to fail before it can start.
joeyparrish added a commit that referenced this pull request Feb 26, 2024
The issue we had in less.js v4 has since been resolved. This updates to
less.js v4.2.0, which includes the underlying fix from its dependency,
needle v3.1.0.

Unforking also resolves CI issues where gitpkg.now.sh temporarily fails
to load, causing the whole test run to fail before it can start.
joeyparrish added a commit that referenced this pull request Feb 27, 2024
The issue we had in less.js v4 has since been resolved. This updates to
less.js v4.2.0, which includes the underlying fix from its dependency,
needle v3.1.0.

Unforking also resolves CI issues where gitpkg.now.sh temporarily fails
to load, causing the whole test run to fail before it can start.

Backported to v4.3.x
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 21, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants