Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Store bandwidth info inside references. #6825

Merged
merged 11 commits into from
Jul 23, 2024
Merged

feat: Store bandwidth info inside references. #6825

merged 11 commits into from
Jul 23, 2024

Conversation

theodab
Copy link
Contributor

@theodab theodab commented Jun 14, 2024 •
edited
Loading

Issue #6725

@theodab theodab added the type: enhancement New feature or request label Jun 14, 2024
@theodab theodab requested a review from avelad June 14, 2024 09:07
@avelad avelad added the priority: P3 Useful but not urgent label Jun 14, 2024
@avelad avelad added this to the v4.10 milestone Jun 14, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented Jun 14, 2024 •
edited
Loading

Incremental code coverage: 90.91%

@caridley caridley mentioned this pull request Jun 14, 2024
Closed
caridley
caridley reviewed Jun 14, 2024
View reviewed changes
lib/player.js Outdated Show resolved Hide resolved
joeyparrish
joeyparrish previously requested changes Jun 18, 2024
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't appear to solve the problem, because we don't map the timeline to variants/streams.

@avelad avelad modified the milestones: v4.10, v4.11 Jul 1, 2024
@avelad avelad mentioned this pull request Jul 19, 2024
Merged
avelad added a commit that referenced this pull request Jul 20, 2024
@avelad
feat: Add getFetchedPlaybackInfo method (#7074)
ef02763 
Related to #6825
@theodab theodab changed the title feat: Add getCurrentPlaybackInfo method to Player feat: Store bandwidth info inside references. Jul 23, 2024
@avelad avelad dismissed joeyparrish’s stale review July 23, 2024 12:17

The scope has changed

@avelad avelad merged commit b4e04b6 into shaka-project:main Jul 23, 2024
12 of 15 checks passed
@shaka-bot shaka-bot mentioned this pull request Jul 23, 2024
Merged
@theodab theodab deleted the getCodecsBranch branch July 23, 2024 20:04
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Sep 21, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Sep 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkatsev gkatsev gkatsev left review comments

@caridley caridley caridley left review comments

@avelad avelad avelad approved these changes

@joeyparrish joeyparrish joeyparrish left review comments

Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.11
Development

Successfully merging this pull request may close these issues.
6 participants
@theodab @shaka-bot @gkatsev @joeyparrish @caridley @avelad