fix(DASH): Fix period combining when roles are equal #7065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avelad
added
type: bug
gkatsev
approved these changes
Jul 18, 2024
|
Incremental code coverage: 100.00% |
avelad
approved these changes
Jul 19, 2024
avelad
pushed a commit
that referenced
this pull request
Jul 22, 2024
When roles exist and are equal between tracks and periods, period combiner matches based on that instead of looking for other similarities. This PR addresses it & adds regression test.
avelad
pushed a commit
that referenced
this pull request
Jul 22, 2024
When roles exist and are equal between tracks and periods, period combiner matches based on that instead of looking for other similarities. This PR addresses it & adds regression test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When roles exist and are equal between tracks and periods, period combiner matches based on that instead of looking for other similarities. This PR addresses it & adds regression test.