Add support for non-standard DASH label attribute #811

itaykinnrot · 2017-05-17T13:12:34Z

No description provided.

joeyparrish · 2017-05-18T17:24:59Z

@itaykinnrot, can you provide us with some idea of what this feature is? You didn't put a description in the PR.

itaykinnrot · 2017-05-18T18:00:06Z

Sure - we want to allow customization of the label that the player show in the menu (same as HLS) and I think that the right way to do it is using the DASH manifest since the packager that create it already has all this data.

erankor · 2017-05-18T18:50:36Z

@joeyparrish, to add to what @itaykinnrot wrote - when playing a stream with multiple audio tracks, currently the only way to identify the different tracks is using the lang attribute of AdaptationSet. We have customers who would like to customize the label that is displayed to the end user for selecting the audio track. Also, multiple audio tracks are sometimes used for uses cases which are not multiple languages, for example - one audio track with background music and one without it.
While it is possible to pass this info out-of-band, we feel it makes most sense to pass it in-band in the MPD. Other protocols have support for this - in HLS you can set the NAME attribute of EXT-X-MEDIA, and in MSS there's a Name attribute on StreamIndex.

joeyparrish · 2017-05-19T22:51:08Z

@erankor, thank you for the context, particularly on HLS. It makes perfect sense. I filed #825 to follow up on the HLS NAME attribute.

joeyparrish

Thank you for the contribution! I have some feedback for you to before we merge.

joeyparrish · 2017-05-19T22:52:20Z

lib/dash/dash_parser.js

@@ -957,11 +957,14 @@ shaka.dash.DashParser.prototype.parseAdaptationSet_ = function(context, elem) {
  var language =
      shaka.util.LanguageUtils.normalize(elem.getAttribute('lang') || 'und');

+  var label =
+      shaka.util.LanguageUtils.normalize(elem.getAttribute('label') || 'und');


I don't think it makes sense to pass the label through language tools or default to the language code 'und'. Label, as I understand it from @erankor's explanation, is a free-form string and may reasonably be missing (null).

joeyparrish · 2017-05-19T22:53:44Z

lib/dash/dash_parser.js

@@ -1105,6 +1109,7 @@ shaka.dash.DashParser.prototype.parseRepresentation_ = function(
    encrypted: contentProtection.drmInfos.length > 0,
    keyId: keyId,
    language: language,
+    label: label,


Please add this new field to the definition of the shakaExtern.Stream structure in externs/shaka/manifest.js.

joeyparrish · 2017-05-19T22:55:42Z

lib/util/stream_utils.js

@@ -233,6 +233,9 @@ shaka.util.StreamUtils.getVariantTracks =
    if (variant.audio) {
      if (codecs != '') codecs += ', ';
      codecs += variant.audio.codecs;
+      if (variant.audio.label) {
+        variant.label = variant.audio.label;


It doesn't make sense to push it from variant.audio (Stream structure) to variant (Variant structure) in this utility. If you need this on variant, you should add it when the variant is generated in the DASH parser.

Instead, though, I recommend just storing the label in a local var. I don't see any good reason to push it up to the variant.

joeyparrish · 2017-05-19T22:56:08Z

test/dash/dash_parser_manifest_unit.js

@@ -119,7 +119,7 @@ describe('DashParser Manifest', function() {
          '      <Representation bandwidth="50" width="576" height="432" />',
          '    </AdaptationSet>',
          '    <AdaptationSet mimeType="text/vtt"',
-          '        lang="es">',
+          '        lang="es" label="spanish">',


Thank you for updating the tests!

joeyparrish · 2017-05-19T22:56:53Z

lib/util/stream_utils.js

@@ -251,6 +254,7 @@ shaka.util.StreamUtils.getVariantTracks =
      type: 'variant',
      bandwidth: variant.bandwidth,
      language: variant.language,
+      label: variant.label,


Please add this new field to the definition of the shakaExtern.Track structure in externs/shaka/player.js.

joeyparrish · 2017-05-19T23:03:37Z

demo/info_section.js

@@ -198,7 +197,11 @@ shakaDemo.updateLanguageOptions_ =
  // Populate list with new options.
  languages.forEach(function(lang) {
    var option = document.createElement('option');
-    option.textContent = lang;
+    var currentTrack = tracks.filter(function(track) {


There are two things wrong with this part:

currentTrack is a misleading name. It is not the currently-selected track you've identified, it's just any track that matches the language.

You shouldn't annotate the languages with track labels. Instead, annotate the track list.

For example, if you have two tracks of the same language, as @erankor suggested is common for this feature, you would have these tracks:

[ { id: 1, lang: 'en', label: 'with music' }, { id: 2, lang: 'en', label: 'without music' }, ]

But the only language in the language list will be "en". With what you've written, your language options in HTML would wind up as:

<select> <option value="en">with music</option> </select>

While the variant tracks would still both show "language: en" with no differentiation.

I think the method you really want to modify here is shakaDemo.updateTrackOptions_, specifically the formatters callbacks.

joeyparrish · 2017-05-19T23:04:51Z

test/test/util/manifest_generator.js

+ * @return {!shaka.test.ManifestGenerator}
+ */
+shaka.test.ManifestGenerator.prototype.label = function(label) {
+  this.currentStreamOrVariant_().label = label;


Please use currentStream_() instead, since this attribute should only live at the stream level.

shakaExtern.Track and shakaExtern.Stream and update project according to it

itaykinnrot · 2017-05-22T11:55:00Z

@joeyparrish thanks for the review - code is update - let me know if anything is missing - Thanks!

joeyparrish · 2017-05-22T18:55:42Z

demo/info_section.js

  var tracks = player.getTextTracks();
+  var languages = tracks.map(function(track) {
+    return { id: track.id, lang: track.language, label: track.label};


The variable name languages is now a misnomer. You're not passing an array of language strings, but an array of objects with track info.

In fact, these objects are a subset of what is already in tracks. So you don't need this at all.

At a higher level, what you're doing here in the UI is labeling the languages. Instead, you should be labeling the tracks, since labels are attached to tracks.

The language list should stay as it is.

joeyparrish · 2017-05-22T19:05:27Z

lib/player.js

 * @param {string} kind
 * @param {string} mime
 * @param {string=} opt_codec
 * @return {!Promise.<shakaExtern.Track>}
 * @export
 */
 shaka.Player.prototype.addTextTrack = function(
-    uri, language, kind, mime, opt_codec) {
+    uri, language, label, kind, mime, opt_codec) {


Please do not add additional parameters to the middle of an exported method. This would break backward compatibility. Instead, make it an optional parameter after opt_codec.

joeyparrish · 2017-05-22T19:06:12Z

lib/util/stream_utils.js

@@ -233,6 +234,9 @@ shaka.util.StreamUtils.getVariantTracks =
    if (variant.audio) {
      if (codecs != '') codecs += ', ';
      codecs += variant.audio.codecs;
+      if (variant.audio.label) {


This "if" is unnecessary. Just set label = variant.audio.label.

joeyparrish · 2017-05-22T19:06:30Z

lib/util/stream_utils.js

@@ -219,6 +219,7 @@ shaka.util.StreamUtils.getVariantTracks =
    function(period, activeAudioId, activeVideoId) {
  var StreamUtils = shaka.util.StreamUtils;
  var variants = StreamUtils.getPlayableVariants(period.variants);
+  var label;


Initialize this to null, since the type allows for null instead of undefined. A minor difference, I know.

joeyparrish · 2017-05-22T19:08:43Z

test/test/util/manifest_generator.js

@@ -353,7 +365,8 @@ shaka.test.ManifestGenerator.prototype.addAudio = function(id) {
  }

  if (!stream)
-    stream = this.createStream_(id, ContentType.AUDIO, variant.language);
+    stream = this.createStream_(id, ContentType.AUDIO, variant.language,
+        variant.audio.label);


This looks like it will throw an exception, since variant.audio doesn't exist yet.

joeyparrish · 2017-05-22T19:09:05Z

test/test/util/manifest_generator.js

 * @return {!shakaExtern.Stream}
 * @private
 */
 shaka.test.ManifestGenerator.prototype.createStream_ =
-    function(id, type, language) {
+    function(id, type, language, label) {


Since you have the label() method to set the label of the current stream, I think we don't need to add this parameter.

joeyparrish · 2017-05-22T19:09:12Z

test/test/util/manifest_generator.js

@@ -456,6 +470,7 @@ shaka.test.ManifestGenerator.prototype.createStream_ =
    encrypted: false,
    keyId: null,
    language: language,
+    label: label,


Default to null.

joeyparrish · 2017-05-23T17:12:22Z

demo/info_section.js

@@ -196,11 +195,11 @@ shakaDemo.updateLanguageOptions_ =
  var selectedTrack = activeTracks[0];

  // Populate list with new options.
-  languages.forEach(function(lang) {
+  tracks.forEach(function(track) {


updateLanguageOptions_ updates the list of languages in the demo. You should not be changing this method.

Instead, you should be changing the formatting in the list of tracks.

Everything else looks good, so I'm going to go ahead and run tests on the build bot. If all tests pass, I will fix the demo UI myself when I merge.

Tests are failing, so I will leave it to you to make updates.

For the demo app, please revert changes in this file and look at the formatters map in updateTrackOptions_. That is where you should add labels to the track list. Here's a suggestion:

shakaDemo.updateTrackOptions_ = function(list, tracks, language) { var formatters = { variant: function(track) { var trackInfo = ''; if (track.language) trackInfo += 'language: ' + track.language + ', '; if (track.label) trackInfo += 'label: ' + track.label + ', '; if (track.width && track.height) trackInfo += track.width + 'x' + track.height + ', '; trackInfo += track.bandwidth + ' bits/s'; return trackInfo; }, text: function(track) { var trackInfo = 'language: ' + track.language + ', '; if (track.label) trackInfo += 'label: ' + track.label + ', '; trackInfo += 'kind: ' + track.kind; return trackInfo; } };

shaka-bot · 2017-05-23T17:23:57Z

Test Failure:

Chrome 58.0.3029 (Linux 0.0.0)
  HlsParser parses video only variant FAILED
    Expected $.presentationTimeline = ({ presentationStartTime_: null, presentationDelay_: 0, duration_: 5, segmentAvailabilityDuration_: Infinity, maxSegmentDuration_: 5, clockOffset_: 0, static_: true }) to equal <jasmine.any()>.
    Expected $.periods[0].startTime = 0 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].id = 2 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].video to have properties
        label: null
        at test/hls/hls_parser_unit.js:61:49
        at <anonymous>
    
  HlsParser parses audio and video variant FAILED
    Expected $.presentationTimeline = ({ presentationStartTime_: null, presentationDelay_: 0, duration_: 5, segmentAvailabilityDuration_: Infinity, maxSegmentDuration_: 5, clockOffset_: 0, static_: true }) to equal <jasmine.any()>.
    Expected $.periods[0].startTime = 0 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].id = 3 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].audio to have properties
        label: null
    Expected $.periods[0].variants[0].video to have properties
        label: null
        at test/hls/hls_parser_unit.js:61:49
        at <anonymous>
    
  HlsParser parses multiple variants FAILED
    Expected $.presentationTimeline = ({ presentationStartTime_: null, presentationDelay_: 0, duration_: 5, segmentAvailabilityDuration_: Infinity, maxSegmentDuration_: 5, clockOffset_: 0, static_: true }) to equal <jasmine.any()>.
    Expected $.periods[0].startTime = 0 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].id = 5 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].audio to have properties
        label: null
    Expected $.periods[0].variants[0].video to have properties
        label: null
    Expected $.periods[0].variants[1].id = 6 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[1].audio to have properties
        label: null
    Expected $.periods[0].variants[1].video to have properties
        label: null
        at test/hls/hls_parser_unit.js:61:49
        at <anonymous>
    
  HlsParser parses multiple streams with the same group id FAILED
    Expected $.presentationTimeline = ({ presentationStartTime_: null, presentationDelay_: 0, duration_: 5, segmentAvailabilityDuration_: Infinity, maxSegmentDuration_: 5, clockOffset_: 0, static_: true }) to equal <jasmine.any()>.
    Expected $.periods[0].startTime = 0 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].id = 4 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].audio to have properties
        label: null
    Expected $.periods[0].variants[0].video to have properties
        label: null
    Expected $.periods[0].variants[1].id = 5 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[1].audio to have properties
        label: null
        at test/hls/hls_parser_unit.js:61:49
        at <anonymous>
    
  HlsParser gets mime type from header request FAILED
    Expected $.presentationTimeline = ({ presentationStartTime_: null, presentationDelay_: 0, duration_: 5, segmentAvailabilityDuration_: Infinity, maxSegmentDuration_: 5, clockOffset_: 0, static_: true }) to equal <jasmine.any()>.
    Expected $.periods[0].startTime = 0 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].id = 2 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].video to have properties
        label: null
        at test/hls/hls_parser_unit.js:61:49
        at <anonymous>
    
  HlsParser parses manifest with text streams FAILED
    Expected $.presentationTimeline = ({ presentationStartTime_: null, presentationDelay_: 0, duration_: 5, segmentAvailabilityDuration_: Infinity, maxSegmentDuration_: 5, clockOffset_: 0, static_: true }) to equal <jasmine.any()>.
    Expected $.periods[0].startTime = 0 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].id = 5 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].audio to have properties
        label: null
    Expected $.periods[0].variants[0].video to have properties
        label: null
    Expected $.periods[0].textStreams[0] to have properties
        label: null
    Expected $.periods[0].textStreams[1] to have properties
        label: null
        at test/hls/hls_parser_unit.js:61:49
        at <anonymous>
    
  HlsParser respects config.hls.defaultTimeOffset setting FAILED
    Expected $.presentationTimeline = ({ presentationStartTime_: null, presentationDelay_: 0, duration_: 5, segmentAvailabilityDuration_: Infinity, maxSegmentDuration_: 5, clockOffset_: 0, static_: true }) to equal <jasmine.any()>.
    Expected $.periods[0].startTime = 0 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].id = 2 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].video to have properties
        label: null
        at test/hls/hls_parser_unit.js:61:49
        at <anonymous>
    
  HlsParser parses video described by a media tag FAILED
    Expected $.presentationTimeline = ({ presentationStartTime_: null, presentationDelay_: 0, duration_: 5, segmentAvailabilityDuration_: Infinity, maxSegmentDuration_: 5, clockOffset_: 0, static_: true }) to equal <jasmine.any()>.
    Expected $.periods[0].startTime = 0 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].id = 3 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].audio to have properties
        label: null
    Expected $.periods[0].variants[0].video to have properties
        label: null
        at test/hls/hls_parser_unit.js:61:49
        at <anonymous>
    
  HlsParser constructs relative URIs FAILED
    Expected $.presentationTimeline = ({ presentationStartTime_: null, presentationDelay_: 0, duration_: 5, segmentAvailabilityDuration_: Infinity, maxSegmentDuration_: 5, clockOffset_: 0, static_: true }) to equal <jasmine.any()>.
    Expected $.periods[0].startTime = 0 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].id = 3 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].audio to have properties
        label: null
    Expected $.periods[0].variants[0].video to have properties
        label: null
        at test/hls/hls_parser_unit.js:485:26
        at <anonymous>
    
  HlsParser allows streams with no init segment FAILED
    Expected $.presentationTimeline = ({ presentationStartTime_: null, presentationDelay_: 0, duration_: 5, segmentAvailabilityDuration_: Infinity, maxSegmentDuration_: 5, clockOffset_: 0, static_: true }) to equal <jasmine.any()>.
    Expected $.periods[0].startTime = 0 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].id = 3 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].audio to have properties
        label: null
    Expected $.periods[0].variants[0].video to have properties
        label: null
        at test/hls/hls_parser_unit.js:61:49
        at <anonymous>
    
  HlsParser constructs DrmInfo for Widevine FAILED
    Expected $.presentationTimeline = ({ presentationStartTime_: null, presentationDelay_: 0, duration_: 5, segmentAvailabilityDuration_: Infinity, maxSegmentDuration_: 5, clockOffset_: 0, static_: true }) to equal <jasmine.any()>.
    Expected $.periods[0].startTime = 0 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].id = 2 to equal <jasmine.any(Number)>.
    Expected $.periods[0].variants[0].video to have properties
        label: null
        at test/hls/hls_parser_unit.js:61:49
        at <anonymous>
    
  OfflineUtils reconstructPeriod will reconstruct Periods correctly FAILED
    Expected object not to have properties
        label: ''
        at verifyStream (test/offline/offline_utils_unit.js:266:22)
        at Object.<anonymous> (test/offline/offline_utils_unit.js:65:7)
    
  OfflineUtils reconstructPeriod will reconstruct Periods correctly FAILED
    Expected object not to have properties
        label: 'English'
        at verifyStream (test/offline/offline_utils_unit.js:266:22)
        at Object.<anonymous> (test/offline/offline_utils_unit.js:66:7)
    
  OfflineUtils reconstructPeriod supports text streams FAILED
    Expected object not to have properties
        label: 'English'
        at verifyStream (test/offline/offline_utils_unit.js:266:22)
        at Object.<anonymous> (test/offline/offline_utils_unit.js:112:7)
    
  Storage lists stored manifests FAILED
    Expected $[0] not to have properties
        label: undefined
        at test/offline/storage_unit.js:166:34
        at <anonymous>
    
  Player tracks returns the correct tracks FAILED
    Expected $[0] not to have properties
        label: null
    Expected $[1] not to have properties
        label: null
    Expected $[2] not to have properties
        label: null
    Expected $[3] not to have properties
        label: null
    Expected $[4] not to have properties
        label: null
        at Object.<anonymous> (test/player_unit.js:905:35)
    
Failed 15 tests, passed 1141, skipped 44

joeyparrish

Please fix the failing tests. You can run the tests yourself locally using python build/test.py (no arguments required).

joeyparrish · 2017-05-23T17:27:16Z

demo/info_section.js

@@ -196,11 +195,11 @@ shakaDemo.updateLanguageOptions_ =
  var selectedTrack = activeTracks[0];

  // Populate list with new options.
-  languages.forEach(function(lang) {
+  tracks.forEach(function(track) {


Tests are failing, so I will leave it to you to make updates.

For the demo app, please revert changes in this file and look at the formatters map in updateTrackOptions_. That is where you should add labels to the track list. Here's a suggestion:

shakaDemo.updateTrackOptions_ = function(list, tracks, language) { var formatters = { variant: function(track) { var trackInfo = ''; if (track.language) trackInfo += 'language: ' + track.language + ', '; if (track.label) trackInfo += 'label: ' + track.label + ', '; if (track.width && track.height) trackInfo += track.width + 'x' + track.height + ', '; trackInfo += track.bandwidth + ' bits/s'; return trackInfo; }, text: function(track) { var trackInfo = 'language: ' + track.language + ', '; if (track.label) trackInfo += 'label: ' + track.label + ', '; trackInfo += 'kind: ' + track.kind; return trackInfo; } };

joeyparrish · 2017-05-23T17:29:21Z

lib/dash/dash_parser.js

@@ -957,11 +957,13 @@ shaka.dash.DashParser.prototype.parseAdaptationSet_ = function(context, elem) {
  var language =
      shaka.util.LanguageUtils.normalize(elem.getAttribute('lang') || 'und');

+  var label = elem.getAttribute('label');


I was unable to find any mention of this attribute in the DASH spec (2014) or the latest DASH-IF-IOP (v4.0). I don't object to you adding it, though.

Please add a comment that this is a non-standard attribute supported by Kaltura.

joeyparrish

Only one small nit. Thanks!

joeyparrish · 2017-05-24T18:06:42Z

lib/hls/hls_parser.js

@@ -526,12 +528,13 @@ shaka.hls.HlsParser.prototype.createStreamInfoFromVariantTag_ =
 * @param {?number} timeOffset
 * @param {!string} language
 * @param {boolean} primary
+ * @param {?string=} opt_label


This probably doesn't need to be both optional and nullable. For an internal method like this, all the arguments should be required, I think.

joeyparrish · 2017-05-24T18:07:59Z

lib/hls/hls_parser.js

@@ -480,6 +480,8 @@ shaka.hls.HlsParser.prototype.createStreamInfoFromMediaTag_ =
  var LanguageUtils = shaka.util.LanguageUtils;
  var langAttr = tag.getAttribute('LANGUAGE');
  var language = langAttr ? LanguageUtils.normalize(langAttr.value) : 'und';
+  var labelAttr = tag.getAttribute('NAME');


Thank you for adding HLS support in this PR as well!

itaykinnrot · 2017-05-25T06:31:01Z

@joeyparrish please review - thanks!

shaka-bot · 2017-05-25T16:57:14Z

All tests passed!

joeyparrish · 2017-05-25T17:43:31Z

Thank you for your contribution!

Change-Id: Iaed56bdbc2937006746ee433e2f13af08e3e585d

* add support for non-standard DASH label attribute * add support for HLS NAME attribute Closes #825

Change-Id: Iaed56bdbc2937006746ee433e2f13af08e3e585d

joeyparrish · 2017-06-05T21:51:04Z

Cherry-picked to v2.1.3.

add support to label attribute for audio and text

34607c9

joeyparrish mentioned this pull request May 19, 2017

HLS NAME attribute not supported #825

Closed

joeyparrish requested changes May 19, 2017

View reviewed changes

joeyparrish added the type: enhancement New feature or request label May 19, 2017

joeyparrish self-assigned this May 19, 2017

fix code review, add label to

272334e

shakaExtern.Track and shakaExtern.Stream and update project according to it

joeyparrish requested changes May 22, 2017

View reviewed changes

more fixes

474add7

joeyparrish reviewed May 23, 2017

View reviewed changes

joeyparrish requested changes May 23, 2017

View reviewed changes

joeyparrish changed the title ~~add support for label attribute - audio and text~~ Add support for non-standard DASH label attribute May 23, 2017

fix unit test + add HLS NAME attribute as label

71e2ade

joeyparrish requested changes May 24, 2017

View reviewed changes

tdaines mentioned this pull request May 24, 2017

Request to expose audio track role #767

Closed

update from master and fix test

2a1d135

joeyparrish approved these changes May 25, 2017

View reviewed changes

joeyparrish merged commit 1519302 into shaka-project:master May 25, 2017

shaka-bot pushed a commit that referenced this pull request May 25, 2017

Minor cleanup after #811

bd79d60

Change-Id: Iaed56bdbc2937006746ee433e2f13af08e3e585d

joeyparrish pushed a commit that referenced this pull request Jun 5, 2017

Add support for DASH label and HLS NAME attributes (#811)

2841de2

* add support for non-standard DASH label attribute * add support for HLS NAME attribute Closes #825

joeyparrish added a commit that referenced this pull request Jun 5, 2017

Minor cleanup after #811

8fe0c2d

Change-Id: Iaed56bdbc2937006746ee433e2f13af08e3e585d

itaykinnrot mentioned this pull request Oct 4, 2017

Add label attribute for audio and captions as optional [3.2.4. Presence of Attributes and Elements] Dash-Industry-Forum/DASH-IF-IOP#139

Open

bvc3at mentioned this pull request Oct 14, 2019

Support label non-standard dash attribute sangwonl/python-mpegdash#32

Closed

bvc3at mentioned this pull request May 3, 2020

Introduce multi audio tracks with same language support axiomatic-systems/Bento4#492

Closed

github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023

github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for non-standard DASH label attribute #811

Add support for non-standard DASH label attribute #811

itaykinnrot commented May 17, 2017

joeyparrish commented May 18, 2017

itaykinnrot commented May 18, 2017

erankor commented May 18, 2017

joeyparrish commented May 19, 2017

joeyparrish left a comment

joeyparrish May 19, 2017

joeyparrish May 19, 2017

joeyparrish May 19, 2017

joeyparrish May 19, 2017

joeyparrish May 19, 2017

joeyparrish May 19, 2017

joeyparrish May 19, 2017

itaykinnrot commented May 22, 2017

joeyparrish May 22, 2017

joeyparrish May 22, 2017

joeyparrish May 22, 2017

joeyparrish May 22, 2017

joeyparrish May 22, 2017

joeyparrish May 22, 2017

joeyparrish May 22, 2017

joeyparrish May 23, 2017

joeyparrish May 23, 2017

shaka-bot commented May 23, 2017

joeyparrish left a comment

joeyparrish May 23, 2017

joeyparrish May 23, 2017

joeyparrish left a comment

joeyparrish May 24, 2017

joeyparrish May 24, 2017

itaykinnrot commented May 25, 2017

shaka-bot commented May 25, 2017

joeyparrish commented May 25, 2017

joeyparrish commented Jun 5, 2017

Add support for non-standard DASH label attribute #811

Add support for non-standard DASH label attribute #811

Conversation

itaykinnrot commented May 17, 2017

joeyparrish commented May 18, 2017

itaykinnrot commented May 18, 2017

erankor commented May 18, 2017

joeyparrish commented May 19, 2017

joeyparrish left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

itaykinnrot commented May 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

shaka-bot commented May 23, 2017

joeyparrish left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joeyparrish left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

itaykinnrot commented May 25, 2017

shaka-bot commented May 25, 2017

joeyparrish commented May 25, 2017

joeyparrish commented Jun 5, 2017