Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to expose audio track role #767

Closed
forbesjo opened this issue Apr 27, 2017 · 9 comments
Closed

Request to expose audio track role #767

forbesjo opened this issue Apr 27, 2017 · 9 comments
Assignees
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone

Comments

@forbesjo
Copy link

This is a enhancement request for exposing an audio track's role in order to differentiate between a main English track and commentary (or any other role type that can share a language).

@ismena
Copy link
Contributor

ismena commented Apr 28, 2017

I think we can do that! Let me tentatively schedule it for 2.2 (tentatively in case our project visionaries don't approve :)).

Please note, that we don't have separate audio/video tracks anymore. Instead we have variant tracks which represent audio+video combinations. (This was introduced in 2.1 release which just went out).

@ismena ismena added flag: good first issue This might be a relatively easy issue; good for new contributors type: enhancement New feature or request labels Apr 28, 2017
@ismena ismena added this to the v2.2.0 milestone Apr 28, 2017
@forbesjo
Copy link
Author

Yep, I've taken that into account in the Shaka/dash.js compatible video.js plugin I'm working on

@ismena ismena assigned ismena and michellezhuogg and unassigned ismena May 1, 2017
@tdaines
Copy link

tdaines commented May 4, 2017

+1 for this. Will getAudioLanguages() and setAudioLanguage() also be modified so that an English commentary track can be selected when the main track is English as well?

@joeyparrish
Copy link
Member

I don't see why not. We'll do that, as well.

@tdaines
Copy link

tdaines commented May 5, 2017

Great thanks. If you prefer that to be in a separate issue I'm happy to make a new one.

@joeyparrish
Copy link
Member

No, I think we can do that here.

@tdaines
Copy link

tdaines commented May 24, 2017

@joeyparrish How do see audio track role coexisting with the label attribute being added by PR #811?

@joeyparrish
Copy link
Member

There can only be one label (one label attribute in DASH, one NAME attribute in HLS). There can be multiple roles in DASH, so the exposed role information will be an array.

Both accomplish similar goals. Whichever is used by your content/encoder, we will expose the information so that your application can use it to make decisions.

shaka-bot pushed a commit that referenced this issue May 26, 2017
This change is to expose an audio track's role in order to differentiate
among a main / caption / commentary track that shares the same
language.

Issue #767.

Change-Id: I05d38cba2170d0005611cf160b7ae45996fe77dd
joeyparrish pushed a commit that referenced this issue Jun 5, 2017
This change is to expose an audio track's role in order to differentiate
among a main / caption / commentary track that shares the same
language.

Issue #767.

Change-Id: I05d38cba2170d0005611cf160b7ae45996fe77dd
@joeyparrish
Copy link
Member

The first part of this fix has been cherry-picked to v2.1.3.

joeyparrish pushed a commit that referenced this issue Jun 15, 2017
Exposing the roles of tracks, which come from the manifest, in the
select audio language method. This is a follow up on commit
b27861050c11451db57d87270ec1385c1906627a.

Closes #767.

Change-Id: Iebb873f1db8834c7275a8a9fc01c3b855c0288aa
@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants