Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appStyles, etc. missing for default config path #151

Closed
bmancini42 opened this issue Aug 30, 2016 · 7 comments
Closed

appStyles, etc. missing for default config path #151

bmancini42 opened this issue Aug 30, 2016 · 7 comments

Comments

@bmancini42
Copy link

If you provide config in the default file path (i.e. ./.boostraprc), values for

  • appStyles
  • preBootstrapCustomizations
  • bootstrapCustomizations

are ignored. This problem was introduced here: 9ef2e35#diff-0b69986665a247a8a8e5e872e1df7022L98

It could be fixed by adding these lines:

      preBootstrapCustomizations: _defaultConfig.preBootstrapCustomizations,
      bootstrapCustomizations: _defaultConfig.bootstrapCustomizations,
      appStyles: _defaultConfig.appStyles,

starting at https://github.com/shakacode/bootstrap-loader/blob/v1/src/bootstrap.config.js#L92

@bmancini42
Copy link
Author

I'd be happy to create a PR, given privileges to this repo.

@justin808
Copy link
Member

@bmancini42 Please create a fork to create a PR. If you can show this error in the /examples directories, even better!

BIG Thanks!

@justin808
Copy link
Member

@bmancini42 Please submit a PR today. Otherwise, @AlexKVal or I will fix later today.

@AlexKVal
Copy link
Contributor

#153

justin808 pushed a commit that referenced this issue Aug 30, 2016
@bmancini42
Copy link
Author

That was fast! Thanks guys.

@justin808
Copy link
Member

Please try out 1.1.3!

@bmancini42
Copy link
Author

Yep, works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants