-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression for supporting the default location of the .bootstraprc #147
Conversation
bootstrap@4.0.0-alpha.3 version throws error
Reviewed 7 of 11 files at r1. src/bootstrap.config.js, line 26 [r1] (raw file):
Do we need a try/catch block? I guess the strategy is just to let the error go to the top level. this is the right error: Comments from Reviewable |
GREAT JOB @AlexKVal! Just the one change to the message.... Reviewed 4 of 11 files at r1. Comments from Reviewable |
#147) * Fix regression for supporting the default location of the .bootstraprc * Log the path of config file used * Global => local variables * We don't need userConfigFileExists() function * Simplify a bit setConfigVariables() * Rename configFilePath => customConfigFilePath * Rename defaultConfigPath => configFilePath * Rename configFile => configFilePath * Rename rawConfig => userConfig * Begin splitting of setConfigVariables(). Move out readUserConfig() part * Transform setConfigVariables() => readDefaultConfig() * Refactor readDefaultConfig() * DRY a bit readDefaultConfig() and readUserConfig() * Refactor parseConfigFile() * Move defaultUserConfigPath. It belongs to readDefaultConfig() * Examples work only with bootstrap@4.0.0-alpha.2 version bootstrap@4.0.0-alpha.3 version throws error * Fix examples' readme files and npm-scripts * Update Changelog
#147) * Fix regression for supporting the default location of the .bootstraprc * Log the path of config file used * Global => local variables * We don't need userConfigFileExists() function * Simplify a bit setConfigVariables() * Rename configFilePath => customConfigFilePath * Rename defaultConfigPath => configFilePath * Rename configFile => configFilePath * Rename rawConfig => userConfig * Begin splitting of setConfigVariables(). Move out readUserConfig() part * Transform setConfigVariables() => readDefaultConfig() * Refactor readDefaultConfig() * DRY a bit readDefaultConfig() and readUserConfig() * Refactor parseConfigFile() * Move defaultUserConfigPath. It belongs to readDefaultConfig() * Examples work only with bootstrap@4.0.0-alpha.2 version bootstrap@4.0.0-alpha.3 version throws error * Fix examples' readme files and npm-scripts * Update Changelog
Replaces and continues #142
I've untangled the lot of knots 😄
To facilitate review process I've committed (almost) each step.
I checked both examples with these commands:
general part:
testing:
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)