Merge pr 194 into master #195
Conversation
|
@navarroaxel We cannot merge your change into master. Please sync up and try it out. Both production and dev versions of your examples crash on startup. CC: @Judahmeek |
|
@justin808 I will try. |
|
Here's my crack at fixing the issues: https://github.com/judahmeek/bootstrap-loader/tree/merge-pr-194-into-master I didn't actually check the resulting webpages, but I got webpack to run without crashing or producing config errors. |
|
@Judahmeek and @navarroaxel Please collaborate! |
* fix config as global var and example with multiple entries * updated README and CONTRIBUTING with new example * travis build on nodejs 6.x
0.25 crashes: #191 0.24 works, but now with the multiple-examples
* fix config * fixed lint issues and multiple-enties package.json
justin808
force-pushed
the
merge-pr-194-into-master
branch
from
f0d86ae
to
ab57d54
Compare
|
The reason that Travis is currently failing is because webpack just got a https://github.com/shakacode/bootstrap-loader/blob/merge-pr-194-into-master/.travis.yml#L10 needs to match https://github.com/shakacode/bootstrap-loader/blob/merge-pr-194-into-master/package.json#L44 |
|
Reviewed 21 of 28 files at r1, 4 of 9 files at r2, 8 of 8 files at r3, 1 of 1 files at r4, 1 of 1 files at r5. Comments from Reviewable |
This change is