Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createUserImport should pass an absolute path to webpack.addDependency #212

Merged
merged 1 commit into from
Nov 23, 2016

Conversation

stephanwilliams
Copy link
Contributor

@stephanwilliams stephanwilliams commented Nov 22, 2016

webpack expects an absolute path.

Fixes #211 .

I updated the relevant test as well and npm run test succeeds, are there any other issues?


This change is Reviewable

@justin808
Copy link
Member

:lgtm:

This looks really great.

@Judahmeek, maybe take a peek at this.


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@justin808
Copy link
Member

@stephanwilliams are you 100% that this is correct (I haven't tested this myself). Should this be merged into the v1 branch?

@stephanwilliams
Copy link
Contributor Author

Managed to find some docs on this, this documentation under Mark Dependencies and Resolve Dependencies seems to indicate that the path should be resolved (i.e. made absolute) by the loader in the case where it's adding the dependency directly and not transforming it into a require(...).

I've been developing with this change applied locally and haven't encountered any issues, and haven't had any further trouble with the webpack --watch problems I described in #211.

As far as I can tell webpack handles this the same between v1 and v2 so it seems this should be merged into both the v1 and master branches.

@justin808 justin808 merged commit 5d6ed4b into shakacode:master Nov 23, 2016
justin808 pushed a commit that referenced this pull request Nov 24, 2016
justin808 added a commit that referenced this pull request Nov 24, 2016
* createUserImport should pass an absolute path to webpack.addDependency (#212)
   webpack expects an absolute path.

* Update all node dependencies (#215)
* 6.9.1 for node. 7.x is not supported yet.
* Used command `ncu -a -u` from npm-check-updates.
* Added webpack to dev dependencies for running tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants