-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow styleLoaders to depends to env #222
Conversation
``` "env": { "development": { "styleLoaders": ["style-loader", "css-loader", "resolve-url-loader", "sass-loader"], "extractStyles": false }, "production": { "styleLoaders": ["style-loader", "css-loader", "sass-loader"], "extractStyles": true } } ```
If we're going to do this, we'd need a readme note on this, as well as a changelog entry. |
There is already the My use case, this avoids having to create 2 files: "env": {
"development": {
"styleLoaders": ["style-loader", "css-loader", "resolve-url-loader", "sass-loader"],
"extractStyles": false
},
"production": {
"styleLoaders": ["style-loader", "css-loader", "sass-loader"],
"extractStyles": true
}
} I do not think there's any need for additional testing. I updated version, changelog and readme. |
Update version, changelog & readme
This looks good with one tiny thing. @Judahmeek, do you concur? Reviewed 2 of 4 files at r2, 1 of 1 files at r4. CHANGELOG.md, line 8 at r4 (raw file):
@bertho-zero You missed the change at the bottom of the file. Comments from Reviewable |
Reviewed 1 of 4 files at r2. Comments from Reviewable |
It is done |
Looks good to me. |
Reviewed 1 of 1 files at r5. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions. README.md, line 224 at r5 (raw file):
@bertho-zero Can you do me a favor and create 3 different fenced code blocks with a short description of each technique. It's not appropriate to put this all in one code block as if you'd do this all in the same file. Comments from Reviewable |
@bertho-zero Please update one thing in the README.md Review status: all files reviewed at latest revision, 2 unresolved discussions. Comments from Reviewable |
I separated the example of other, yes it was confused. On the other hand I do not see what examples I could add.. Not speaking very good English, I do not know what to add to the readme. |
Allow styleLoaders to depend on env ``` "env": { "development": { "styleLoaders": ["style-loader", "css-loader", "resolve-url-loader", "sass-loader"], "extractStyles": false }, "production": { "styleLoaders": ["style-loader", "css-loader", "sass-loader"], "extractStyles": true } } ``` * Update bootstrap.config.js * Update package.json * support styleLoaders env with userConfig
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)