travis passing #259
travis passing #259
Conversation
|
@Judahmeek Thank you so much! @alexfedoseev LGTM. OK with you? |
.travis.yml
Outdated
| @@ -1,14 +1,9 @@ | |||
| language: node_js | |||
|
|
|||
| node_js: | |||
| - "6" | |||
| - "7" | |||
There was a problem hiding this comment.
Let's test on at least 3 major versions?
node_js:
- "5"
- "6"
- "7"| @@ -35,5 +35,5 @@ Error: ${error} | |||
| .map(loader => `${loader}!`) | |||
| .join('') | |||
| ); | |||
| return ExtractTextPlugin.extract({ fallbackLoader, loader: restLoaders }); | |||
| return ExtractTextPlugin.extract({ fallback: fallbackLoader, use: restLoaders }); | |||
There was a problem hiding this comment.
We have this ongoing PR. TBH I haven't looked into details of the issue and not sure why returned value must be a string (when it's changed to array in ETP). Can you check if this resolves #238 or not.
There was a problem hiding this comment.
This PR currently doesn't solve that problem. A string is required by our own code. I just created an amendment that will solve this problem and be completely backwards compatible.
- added yarn support - updated dependencies (eslint-shakacode) - lint passes - specs passes - specs cover utils only though
| @@ -54,7 +54,7 @@ | |||
| "babel-loader": "^6.2.8", | |||
| "babel-preset-es2015": "^6.18.0", | |||
| "body-parser": "^1.15.2", | |||
| "bootstrap-loader": "file:../..", | |||
| "bootstrap-loader": "file:///Users/judahmeek/Apps/bootstrap-loader", | |||
There was a problem hiding this comment.
@Judahmeek I shouldn't have merged this...
Need another PR to fix this.
There was a problem hiding this comment.
| `${ExtractTextPlugin.loader().loader}?{"omit":1,"remove":true}`, | ||
| fallbackLoader, | ||
| restLoaders, | ||
| ].join('!'); |
There was a problem hiding this comment.
@Judahmeek @alexfedoseev
- should this get a new release?
- does this apply to the v1 branch?
There was a problem hiding this comment.
I'm fairly confident that this does not apply to webpack 1. The latest commit for the extract-text-webpack-plugin supporting webpack 1 was back in June 15, 2016: https://github.com/webpack-contrib/extract-text-webpack-plugin/tree/webpack-1
This change is