Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Example Dependencies #261

Merged
merged 2 commits into from
Feb 17, 2017
Merged

Update Example Dependencies #261

merged 2 commits into from
Feb 17, 2017

Conversation

Judahmeek
Copy link
Contributor

@Judahmeek Judahmeek commented Feb 15, 2017

Should be good to go. resolve-url-loader upgraded to ^2.0.0 and examples running and linted.


This change is Reviewable

@justin808
Copy link
Member

yarn or npm?


Reviewed 1 of 13 files at r1, 22 of 22 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.


examples/css-modules/package.json, line 26 at r1 (raw file):

    "bs3:default:prod": "npm run bs3:default:setup && npm run prod",
    "bs4:default:prod": "npm run bs4:default:setup && npm run prod",
    "install-local": "rm -rf node_modules/bootstrap-loader && npm install --save-dev ../.. && npm run post-install"

are we using yarn or npm?

@Judahmeek you are still using npm run here.


examples/css-modules/package.json, line 63 at r1 (raw file):

    "babel-preset-es2015": "^6.18.0",
    "babel-preset-react": "^6.16.0",
    "bootstrap-loader": "file:///Users/judahmeek/Apps/bootstrap-loader",

Can't refer to your local files


Comments from Reviewable

@Judahmeek
Copy link
Contributor Author

Both?


Review status: all files reviewed at latest revision, 2 unresolved discussions.


examples/css-modules/package.json, line 26 at r1 (raw file):

Previously, justin808 (Justin Gordon) wrote…

are we using yarn or npm?

@Judahmeek you are still using npm run here.

I figured we could support both. I ran yarn in terminal and left the scripts as npm. I assume almost anyone who uses yarn can easily set up npm or modify our package.json, but not vice versa (since those with less experience generally start with npm).


examples/css-modules/package.json, line 63 at r1 (raw file):

Previously, justin808 (Justin Gordon) wrote…

Can't refer to your local files

Ouch. Well, I caught 2 out of 3.


Comments from Reviewable

@Judahmeek
Copy link
Contributor Author

Review status: all files reviewed at latest revision, 2 unresolved discussions.


examples/css-modules/package.json, line 63 at r1 (raw file):

Previously, Judahmeek (Judah Meek) wrote…

Ouch. Well, I caught 2 out of 3.

Actually, I've already fixed this. Check the latest revision.


Comments from Reviewable

@justin808
Copy link
Member

@Judahmeek I think the examples should use yarn or npm. I use either, but only one within a project.

@justin808
Copy link
Member

@Judahmeek I'll merge this. Let's put anything pending in the next PR. I'm going to cut a release! 🎉

@justin808 justin808 merged commit 2134437 into shakacode:master Feb 17, 2017
@justin808
Copy link
Member

2.0.0-beta.21 pushed to npm!

@Judahmeek Judahmeek deleted the examples branch March 9, 2017 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants