Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal changes necessary for Webpack 5 compatibility #401

Merged
merged 3 commits into from
Jan 20, 2022

Conversation

Judahmeek
Copy link
Contributor

@Judahmeek Judahmeek commented Jan 17, 2022

Same as #400 without the lib directory.


This change is Reviewable

Copy link
Member

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

questions below

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Judahmeek)


src/utils/processStyleLoaders.js, line 66 at r1 (raw file):

    // eslint-disable-next-line no-param-reassign
    loadersWithSuffix[sassLoaderIndex] = sassLoaderWithSourceMap;
  1. Will this break compat with older webpack?
  2. Can you be sure to put in changelog?

Copy link
Contributor Author

@Judahmeek Judahmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @justin808)


src/utils/processStyleLoaders.js, line 66 at r1 (raw file):

Previously, justin808 (Justin Gordon) wrote…
  1. Will this break compat with older webpack?
  2. Can you be sure to put in changelog?
  1. No, because sass-loader's latest versions already get their default sourceMap config from the devtools configuration.

  2. Sure. How exactly do you want me to phrase it? bootstrap-loader no longer triggers sourceMap for sass-loader?

Copy link
Member

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Judahmeek)


src/utils/processStyleLoaders.js, line 66 at r1 (raw file):

Previously, Judahmeek (Judah Meek) wrote…
  1. No, because sass-loader's latest versions already get their default sourceMap config from the devtools configuration.

  2. Sure. How exactly do you want me to phrase it? bootstrap-loader no longer triggers sourceMap for sass-loader?

Sure -- I really have zero idea on this one.

Copy link
Member

@justin808 justin808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Judahmeek)


src/utils/processStyleLoaders.js, line 66 at r1 (raw file):

Previously, justin808 (Justin Gordon) wrote…

Sure -- I really have zero idea on this one.

maybe just a changelog entry!
maybe a major version bump also!

@justin808
Copy link
Member

Please update the https://github.com/shakacode/bootstrap-loader/blob/master/CHANGELOG.md and I will merge and release.

@justin808 justin808 marked this pull request as ready for review January 20, 2022 05:50
@justin808 justin808 merged commit d8327df into master Jan 20, 2022
@justin808 justin808 deleted the judahmeek/webpack-5-clone branch January 20, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants