Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated project for bootstrap 4, alpha 2 #56

Merged
merged 1 commit into from
Feb 29, 2016

Conversation

justin808
Copy link
Member

  • Added support for postcss and tether for Bootstrap 4.
  • Added font-awesome example usage (no glyphicons in Bootstrap 4).

Things to do someday:

  • It's pretty non-dry for the examples.
  • I couldn't get the extract-text-plugin to work with font-awesome unless I removed the url-loader limit of 10000.

Review on Reviewable

@justin808
Copy link
Member Author

@lazzrek @alexfedoseev @RazkoSA @vjpr please review.

* Added support for postcss and tether for Bootstrap 4.
@byteslicer
Copy link
Contributor

Thanks for creating this Pull request @justin808 . I found some issues:

  • Duplicate 'postcss-loader' in both package.json files.
  • Is it not redundant to require "postcss" if its already installed via postcss-loaders dependency?
  • Move all loaders to "devDependencies"

@justin808
Copy link
Member Author

@lazzrek Can you please attach your comments to lines of code. Click the "Files Changed" tab or go into Reviewable. Thanks.

test: /\.woff2?(\?v=[0-9]\.[0-9]\.[0-9])?$/,
// Limiting the size of the woff fonts breaks font-awesome ONLY for the extract text plugin
// loader: "url?limit=10000"
loader: "url"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexfedoseev @wmadden We need to figure this one out. We should be able to have the url limit when doing a prod (extract-text-plugin) deployment.

@alex35mil
Copy link
Member

Looks good, merging 👍

alex35mil added a commit that referenced this pull request Feb 29, 2016
Updated project for bootstrap 4, alpha 2
@alex35mil alex35mil merged commit 4f244a4 into master Feb 29, 2016
@alex35mil alex35mil deleted the update-bootstrap4-alpha-2 branch February 29, 2016 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants