First do it #60
Closed
First do it #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,3 +23,6 @@ npm-debug.log | |||
|
|
|||
| # Ignore bundle dependencies | |||
| vendor/ruby | |||
|
|
|||
| # RVM gemset | |||
| .ruby-gemset | |||
There was a problem hiding this comment.
Curious if this should be project specific.
There was a problem hiding this comment.
I keep all gems in isolated gemsets for two reasons:
- I maintain
yogenerator, so I scaffold a lot for testing purposes. It's easier for me to delete scaffolded test gems by deleting gemset. - To sleep easily.
There was a problem hiding this comment.
Should .ruby-gemset be in developer's global gitignore?
There was a problem hiding this comment.
Should .ruby-gemset be in developer's global gitignore?
If everybody is using gemset-per-app strategy, then no. Otherwise — yes.
|
@alexfedoseev Looks AWESOME. I'll let you merge this change into the PR on my repo. Please respond to my comments here, however. Please merge --squash your changes on top of mine. |
justin808
added a commit
that referenced
this pull request
Aug 6, 2015
Squash merge of #60 from @alexfedoseev (thanks!) 1. What should we name the reducer? Seems confusing in terms of how the reducer name gets put as part of the state. 2. Functional issue in that we don't clear out the last name/commment after ajax is successful. Seems that we would need to have the component state inside of the main store. 3. Ajax counter to show busy indicator of async in progress might not be working. 4. We should show a simple validation on the server and the display of a simple error message on the form.
justin808
added a commit
that referenced
this pull request
Aug 6, 2015
Squash merge of #60 from @alexfedoseev (thanks!) 1. What should we name the reducer? Seems confusing in terms of how the reducer name gets put as part of the state. 2. Functional issue in that we don't clear out the last name/commment after ajax is successful. Seems that we would need to have the component state inside of the main store. 3. Ajax counter to show busy indicator of async in progress might not be working. 4. We should show a simple validation on the server and the display of a simple error message on the form.
|
Already merged to other PR. Closing. |
justin808
added a commit
that referenced
this pull request
Aug 22, 2015
Squash merge of #60 from @alexfedoseev (thanks!) 1. What should we name the reducer? Seems confusing in terms of how the reducer name gets put as part of the state. 2. Functional issue in that we don't clear out the last name/commment after ajax is successful. Seems that we would need to have the component state inside of the main store. 3. Ajax counter to show busy indicator of async in progress might not be working. 4. We should show a simple validation on the server and the display of a simple error message on the form.
ryanbelke
pushed a commit
to ryanbelke/rails-react-yourtime
that referenced
this pull request
Jan 4, 2019
Squash merge of shakacode/react-webpack-rails-tutorial#60 from @alexfedoseev (thanks!) 1. What should we name the reducer? Seems confusing in terms of how the reducer name gets put as part of the state. 2. Functional issue in that we don't clear out the last name/commment after ajax is successful. Seems that we would need to have the component state inside of the main store. 3. Ajax counter to show busy indicator of async in progress might not be working. 4. We should show a simple validation on the server and the display of a simple error message on the form.
joseph0919
added a commit
to joseph0919/React_Webpack_Rails_Tutorial
that referenced
this pull request
May 3, 2019
Squash merge of shakacode/react-webpack-rails-tutorial#60 from @alexfedoseev (thanks!) 1. What should we name the reducer? Seems confusing in terms of how the reducer name gets put as part of the state. 2. Functional issue in that we don't clear out the last name/commment after ajax is successful. Seems that we would need to have the component state inside of the main store. 3. Ajax counter to show busy indicator of async in progress might not be working. 4. We should show a simple validation on the server and the display of a simple error message on the form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it renders the view, but we should discuss a lot of stuff (: