Skip to content

Commit

Permalink
Update from therubyracer to mini_racer
Browse files Browse the repository at this point in the history
mini_racer is way faster
  • Loading branch information
justin808 committed Aug 22, 2016
1 parent e736d4f commit 2195d28
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 12 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Expand Up @@ -21,7 +21,7 @@ gem "scss_lint", require: false
gem "sdoc", "~> 0.4.0", group: :doc
gem "spring"
gem "sqlite3"
gem "therubyracer"
gem "mini_racer"
if ENV["ENABLE_TURBOLINKS_5"].nil? || ENV["ENABLE_TURBOLINKS_5"].strip.empty?
gem "turbolinks", "2.5.3"
else
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/base_generator.rb
Expand Up @@ -82,7 +82,7 @@ def template_base_files
end

def add_base_gems_to_gemfile
append_to_file("Gemfile", "\ngem 'therubyracer', platforms: :ruby\n")
append_to_file("Gemfile", "\ngem 'mini_racer', platforms: :ruby\n")
end

ASSETS_RB_APPEND = <<-DATA.strip_heredoc
Expand Down
Expand Up @@ -52,7 +52,7 @@ ReactOnRails.configure do |config|

# Server rendering only (not for render_component helper)
# You can configure your pool of JS virtual machines and specify where it should load code:
# On MRI, use `therubyracer` for the best performance
# On MRI, use `mini_racer` for the best performance
# (see [discussion](https://github.com/reactjs/react-rails/pull/290))
# On MRI, you'll get a deadlock with `pool_size` > 1
# If you're using JRuby, you can increase `pool_size` to have real multi-threaded rendering.
Expand Down
4 changes: 2 additions & 2 deletions spec/dummy/Gemfile
Expand Up @@ -13,7 +13,7 @@ gem 'uglifier', '>= 2.7.2'
# Use CoffeeScript for .coffee assets and views
gem 'coffee-rails', '~> 4.1.0'
# See https://github.com/rails/execjs#readme for more supported runtimes
# gem 'therubyracer', platforms: :ruby
# gem 'mini_racer', platforms: :ruby

# Use jquery as the JavaScript library
gem 'jquery-rails'
Expand Down Expand Up @@ -43,7 +43,7 @@ gem 'sdoc', '~> 0.4.0', group: :doc

gem "react_on_rails", path: "../.."

gem "therubyracer"
gem "mini_racer"

# Access an IRB console on exception pages or by using <%= console %> in views
gem 'web-console', group: :development, require: false
Expand Down
10 changes: 4 additions & 6 deletions spec/dummy/Gemfile.lock
Expand Up @@ -118,7 +118,7 @@ GEM
json (1.8.3)
launchy (2.4.3)
addressable (~> 2.3)
libv8 (3.16.14.15)
libv8 (5.0.71.48.3)
loofah (2.0.3)
nokogiri (>= 1.5.9)
mail (2.6.4)
Expand All @@ -128,6 +128,8 @@ GEM
mime-types-data (~> 3.2015)
mime-types-data (3.2016.0221)
mini_portile2 (2.1.0)
mini_racer (0.1.4)
libv8 (~> 5.0, < 5.1.11)
minitest (5.9.0)
multi_json (1.12.0)
nokogiri (1.6.8)
Expand Down Expand Up @@ -191,7 +193,6 @@ GEM
rake (11.2.2)
rdoc (4.2.2)
json (~> 1.4)
ref (2.0.0)
rspec-core (3.4.4)
rspec-support (~> 3.4.0)
rspec-expectations (3.4.0)
Expand Down Expand Up @@ -254,9 +255,6 @@ GEM
sqlite3 (1.3.11)
term-ansicolor (1.3.2)
tins (~> 1.0)
therubyracer (0.12.2)
libv8 (~> 3.16.14.0)
ref
thor (0.19.1)
thread_safe (0.3.5)
tilt (2.0.2)
Expand Down Expand Up @@ -295,6 +293,7 @@ DEPENDENCIES
jbuilder (~> 2.0)
jquery-rails
launchy
mini_racer
poltergeist
pry
pry-byebug
Expand All @@ -313,7 +312,6 @@ DEPENDENCIES
selenium-webdriver
spring
sqlite3
therubyracer
turbolinks (= 2.5.3)
uglifier (>= 2.7.2)
web-console
Expand Down
2 changes: 1 addition & 1 deletion spec/dummy/config/initializers/react_on_rails.rb
Expand Up @@ -64,7 +64,7 @@ def self.custom_context(view_context)

# Server rendering only (not for render_component helper)
# You can configure your pool of JS virtual machines and specify where it should load code:
# On MRI, use `therubyracer` for the best performance
# On MRI, use `mini_racer` for the best performance
# (see [discussion](https://github.com/reactjs/react-rails/pull/290))
# On MRI, you'll get a deadlock with `pool_size` > 1
# If you're using JRuby, you can increase `pool_size` to have real multi-threaded rendering.
Expand Down

0 comments on commit 2195d28

Please sign in to comment.