Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update linters to conform to ShakaCode standards
This change is in parallel with the change made for the webpack tutorial. See shakacode/react-webpack-rails-tutorial#159 - Fix generator linters templating logic for scss task - Remove unnecessary lodash import in generated loggerMiddleware - Exclude dummy apps from linting - Remove unnecessary 'refs' attribute in generated component - Add dummy apps to eslintignore
- Loading branch information
Showing
8 changed files
with
110 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
node_modules | ||
coverage | ||
spec/react_on_rails/dummy-for-generators | ||
spec/dummy | ||
spec/dummy-react-013 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,26 @@ | ||
{ | ||
"preset": "airbnb", | ||
"fileExtensions": [".js", ".jsx"], | ||
"excludeFiles": ["**/build/**", "**/node_modules/**", "**/generated/**", "**/docs/**", "**/tmp/**", "**/sample_generated/**", "**/coverage/**", "**/vendor/**", "**/dummy-for-generators/**"], | ||
"requireTrailingComma": { "ignoreSingleValue": true, "ignoreSingleLine": true }, | ||
"validateQuoteMarks": false | ||
"fileExtensions": [ | ||
".js", | ||
".jsx" | ||
], | ||
"excludeFiles": [ | ||
"**/build/**", | ||
"**/node_modules/**", | ||
"**/generated/**", | ||
"**/docs/**", | ||
"**/tmp/**", | ||
"**/sample_generated/**", | ||
"**/coverage/**", | ||
"**/vendor/**", | ||
"**/dummy-for-generators/**", | ||
"**/dummy/**", | ||
"**/dummy-react-013/**" | ||
], | ||
"esprima": "babel-jscs", | ||
"validateQuoteMarks": { | ||
"mark": "'", | ||
"escape": true, | ||
"ignoreJSX": true | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 15 additions & 4 deletions
19
lib/generators/react_on_rails/templates/js_linters/client/.jscsrc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,18 @@ | ||
{ | ||
"preset": "airbnb", | ||
"fileExtensions": [".js", ".jsx"], | ||
"excludeFiles": ["build/**", "node_modules/**"], | ||
|
||
"validateQuoteMarks": null // Issue with JSX quotemarks: https://github.com/jscs-dev/babel-jscs/issues/12 | ||
"fileExtensions": [ | ||
".js", | ||
".jsx" | ||
], | ||
"excludeFiles": [ | ||
"assets/**", | ||
"build/**", | ||
"node_modules/**" | ||
], | ||
"esprima": "babel-jscs", | ||
"validateQuoteMarks": { | ||
"mark": "'", | ||
"escape": true, | ||
"ignoreJSX": true | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
...rators/react_on_rails/templates/redux/base/client/app/lib/middlewares/loggerMiddleware.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters