Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console logging reports SSR successful when it didn't run #1144

Closed
justin808 opened this issue Sep 14, 2018 · 1 comment
Closed

Console logging reports SSR successful when it didn't run #1144

justin808 opened this issue Sep 14, 2018 · 1 comment

Comments

@justin808
Copy link
Member

During debug tracing, for development, we put a message that SSR ran, but in fact it didn't. This seems to happen if the server bundle is created but doesn't have runnable code (?)

Not a high priority bug.

Easy to see that SSR did not run by looking at the page source.

Also, if the development mode is configured to throw errors on server rendering failure, then the error is obvious.

Best to configure config/initializers/react_on_rails.rb:

  config.raise_on_prerender_error = Rails.env.development? 

and not just always false.

@justin808
Copy link
Member Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant